Hubbub "has_children" tree callback no longer used?

John-Mark Bell jmb at netsurf-browser.org
Wed Feb 12 16:01:18 GMT 2014


On Tue, Feb 11, 2014 at 05:10:35PM +0100, Ralf Junker wrote:
> In Hubbub, the "has_children" tree callback is never used.
>
> It is defined in hubbub\include\hubbub\tree.h, line 286.
>
> With that line commented out, Hubbub still compiles fine and tests pass  
> without error.

Correct: the specification changed under us, which rendered that
callback unused.

> Hence I believe that the "has_children" callback could (and should?) be  
> removed from the hubbub_tree_handler.

That would be an ABI break, which we strive to avoid. However, the next
release of Hubbub already breaks the ABI in other areas, so I'm inclined
to take the opportunity to remove that treebuilder callback entry.

Of course, it might resurface later, should we ever get around to
bringing Hubbub's implementation back in line with the specification.
Somewhat embarrassingly, it's nearly 5 years out of date.


J.



More information about the netsurf-dev mailing list