Tests rely on alloca()

Vincent Sanders vince at netsurf-browser.org
Sat Apr 27 13:29:54 BST 2013


On Fri, Apr 26, 2013 at 09:24:59PM -0600, Anthony J. Bentley wrote:
> "Anthony J. Bentley" writes:
> > Hi,
> > 
> > Several tests use alloca() to allocate memory. But alloca() is not part of
> > C99, and on OpenBSD this leads to linking errors since the NetSurf build
> > system specifies -std=c99:
> > 
> > LINK: build-OpenBSD-OpenBSD-release-lib-shared/test_parser
> > cc -o build-OpenBSD-OpenBSD-release-lib-shared/test_parser build-OpenBSD-Open
> > BSD-release-lib-shared/test_parser.o -Lbuild-OpenBSD-OpenBSD-release-lib-shar
> > ed/ -lhubbub -g -L/usr/local/lib -liconv -L/usr/local/lib -ljson-c
> > build-OpenBSD-OpenBSD-release-lib-shared/test_parser.o(.text+0x578): In funct
> > ion `run_test':
> > test/parser.c:28: undefined reference to `alloca'
> > collect2: ld returned 1 exit status
> 
> I've replaced these with calls to malloc():
> 
> https://github.com/bentley/libcss/
> https://github.com/bentley/libhubbub/
> https://github.com/bentley/libparserutils/

Reviewed and applied, thanks for your work on this

> 
> If these could be pulled into the main repositories that would be great.
> 
> -- 
> Anthony J. Bentley
> 
> 

-- 
Regards Vincent
http://www.kyllikki.org/



More information about the netsurf-dev mailing list