netsurf: branch master updated. release/3.9-72-g54daff0

NetSurf Browser Project (Commit Mailer) no-reply at netsurf-browser.org
Sat Aug 3 14:04:57 BST 2019


Gitweb links:

...log http://git.netsurf-browser.org/netsurf.git/shortlog/54daff0e979a17984d66b06db2adc292f55b7b14
...commit http://git.netsurf-browser.org/netsurf.git/commit/54daff0e979a17984d66b06db2adc292f55b7b14
...tree http://git.netsurf-browser.org/netsurf.git/tree/54daff0e979a17984d66b06db2adc292f55b7b14

The branch, master has been updated
       via  54daff0e979a17984d66b06db2adc292f55b7b14 (commit)
      from  f984873799b30f5bad45f58e456f6f5e8c384c16 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=54daff0e979a17984d66b06db2adc292f55b7b14
commit 54daff0e979a17984d66b06db2adc292f55b7b14
Author: Michael Drake <michael.drake at codethink.co.uk>
Commit: Michael Drake <michael.drake at codethink.co.uk>

    RISC OS: y scroll is negative.

diff --git a/frontends/riscos/corewindow.c b/frontends/riscos/corewindow.c
index ecd2df2..6adfb03 100644
--- a/frontends/riscos/corewindow.c
+++ b/frontends/riscos/corewindow.c
@@ -846,8 +846,12 @@ ro_cw_scroll_visible(struct core_window *cw, const struct rect *r)
 		return;
 	}
 
-	state.xscroll = r->x0 * 2;
-	state.yscroll = r->y0 * 2;
+	/* TODO:
+	 * Scroll so the area is brought into view, not just the top left of
+	 * the rectangle.  See `nsgtk_cw_scroll_visible`.
+	 */
+	state.xscroll = -r->x0 * 2;
+	state.yscroll = -r->y0 * 2;
 
 	ro_cw_open(PTR_WIMP_OPEN(&state));
 }


-----------------------------------------------------------------------

Summary of changes:
 frontends/riscos/corewindow.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/frontends/riscos/corewindow.c b/frontends/riscos/corewindow.c
index ecd2df2..6adfb03 100644
--- a/frontends/riscos/corewindow.c
+++ b/frontends/riscos/corewindow.c
@@ -846,8 +846,12 @@ ro_cw_scroll_visible(struct core_window *cw, const struct rect *r)
 		return;
 	}
 
-	state.xscroll = r->x0 * 2;
-	state.yscroll = r->y0 * 2;
+	/* TODO:
+	 * Scroll so the area is brought into view, not just the top left of
+	 * the rectangle.  See `nsgtk_cw_scroll_visible`.
+	 */
+	state.xscroll = -r->x0 * 2;
+	state.yscroll = -r->y0 * 2;
 
 	ro_cw_open(PTR_WIMP_OPEN(&state));
 }


-- 
NetSurf Browser



More information about the netsurf-commits mailing list