[PATCH] Add loop device support to highbank kernel

Sam Thursfield sam.thursfield at codethink.co.uk
Tue Jun 4 13:59:13 BST 2013


On 04/06/13 13:20, Jonathan Maw wrote:
> On 2013-06-04 11:58, Lars Wirzenius wrote:
>> On Tue, Jun 04, 2013 at 09:40:09AM +0100, Jonathan Maw wrote:
>>> head:   d810db67e2dbcec697338bbdde1805a6816d8f74
>>> branch: baserock/jonathan/arm-highbank-fix
>>> repo:   git://trove.baserock.org/delta/linux
>>> target: baserock/arm/highbank
>>
>> Looks OK to me, though I'm not a kernel expert. OK to merge.
>
> There's one part that popped up and might be worth discussing:
> This differs from the big-endian kernel in that LE has separate
> code for ext2 and ext3, whereas BE uses ext4 as ext2 and ext3.
>
> Back when I submitted this patch, I did so assuming that there
> would be no significant differences in doing this, but have
> seen some discussion that suggests otherwise.
>
> Should I merge this as-is, or should we handle ext2 and ext3 in
> the same way as highbank-be?

I believe using the ext4 driver for everything is the preferred way. 
That's why I did so in the BE kernel.

Apart from anything else, having all 3 enabled means you get a series of 
warnings when mounting an ext4 partition as it first tries to mount as 
ext2, fails, then tries to mount as ext3, fails, and then finally gets 
mounted as ext4 and succeeds.

Sam




More information about the baserock-dev mailing list