[PATCH 4/4] Test that systems can build with YAML morphologies

Richard Maw richard.maw at codethink.co.uk
Tue Jan 22 12:32:00 GMT 2013


On Tue, Jan 22, 2013 at 11:09:54AM +0000, Sam Thursfield wrote:
> I don't think we should spend time converting the whole test suite
> to YAML now, but I do think that we need to pay it more than
> lip-service. Why not remove this test and convert
> tests.as-root/setup itself to use YAML morphologies? We should be
> able to assert just with unit tests that the Morphology class is
> behaves identically given either JSON or YAML input, and therefore
> we can reason that if one builds successfully the other will too.

I shied away from doing this because: there are a lot of tests that
depend on the output being in JSON, and we deliberately write JSON if
the input was JSON; and we've spent longer than we estimated on this
already.

You're correct for the case of building though, they don't alter the
morphologies, so it should not matter if the input changes.
I will attempt this for the next version of the patch series.




More information about the baserock-dev mailing list