[PATCH 2/2] Resolve stratum and chunk refs in batches

Richard Maw richard.maw at codethink.co.uk
Fri Jan 11 11:58:15 GMT 2013


On Mon, Jan 07, 2013 at 06:40:37PM +0000, Jannis Pohlmann wrote:
> I noticed a weird thing in resolve_ref() while I wrote the
> corresponding batch function resolve_refs(): unless I'm misreading
> the code the repository caching at the end of resolve_ref() clones
> repositories from the remote repo cache that already failed to
> resolve the needed ref remotely. How would they be useful after
> cloning? Anyway, resolve_refs() is implemented in the same way
> but I added a FIXME note.

It's so that if the repository it is fetching from does not have a cache
server, it can fall back to cloning, then a local resolve.

In a more general review, I'm worried what would happen if the cache
server doesn't resolving multiple refs, so what happens if people use a
newer morph, but an old cache server.




More information about the baserock-dev mailing list