[PATCH 00/18] Make system artifact building happen in plugins

Lars Wirzenius lars.wirzenius at codethink.co.uk
Thu Jul 26 12:13:22 BST 2012

We want this so it is easy to add new kinds of system artifacts,
e.g., building different kinds of disk images for different kinds of

This is not the cleanest patch series, but I'm not sure it's worth
refactoring the patch series to make the history be pretty.

Since Richard is away, and he's the one best qualified to review this,
I'll merge it myself tonight or tomorrow, unless someone objects.

* Repository: git://roadtrain.codethink.co.uk/baserock/morph
* Branch: liw/systemkindbuilder
* Commit: bc7cc75e6848f4215e522227c19d461473a85303

Lars Wirzenius (18):
  Refactor system building to use syskind specific class
  Move syslinux-disk system building into plugin
  Only provide syslinux-disk on Intel platforms
  Start a tarball systembuilder
  Modify test case for rootfs-tarball (instead of just arm)
  Add test case fof syslinux-disk building
  Remove arch specific test in syslinux-disk builder
  Fix getting name of rootfs files in test case
  Fix code path for error handling
  Move strata unpacking into a base class
  Move fstab creation into base class
  Don't generate extlinux config for rootfs tarball
  Fix rootfs-tarball to create kernel image on all arches
  Refactor: move kernel artifact creation into base class
  Refactor to get rid of undescriptive variable names
  Refactor by breaking long expression into two
  Fix variable reference in test script
  Fix variable reference in test script

 morphlib/app.py                                    |   13 +-
 morphlib/builder2.py                               |  233 ++++++--------------
 .../plugins/syslinux-disk-systembuilder_plugin.py  |  202 +++++++++++++++++
 morphlib/plugins/tarball-systembuilder_plugin.py   |   73 ++++++
 tests.as-root/arm-system-writes-kernel.script      |   82 -------
 tests.as-root/make-patch.script                    |    2 +-
 .../rootfs-tarball-builds-rootfs-and-kernel.script |   95 ++++++++
 tests.as-root/setup                                |    2 +-
 .../syslinux-disk-builds-rootfs-and-kernel.script  |  101 +++++++++
 tests.as-root/system-overlap.script                |    2 +-
 tests.branching/setup                              |    2 +-
 tests/setup                                        |    2 +-
 without-test-modules                               |    3 +
 13 files changed, 558 insertions(+), 254 deletions(-)
 create mode 100644 morphlib/plugins/syslinux-disk-systembuilder_plugin.py
 create mode 100644 morphlib/plugins/tarball-systembuilder_plugin.py
 delete mode 100755 tests.as-root/arm-system-writes-kernel.script
 create mode 100755 tests.as-root/rootfs-tarball-builds-rootfs-and-kernel.script
 create mode 100755 tests.as-root/syslinux-disk-builds-rootfs-and-kernel.script


More information about the baserock-dev mailing list