12:34 a.m.
On Mon, 02 Jul 2012 00:01:40 +0200, Ole wrote:
Almost yes, this patch is working for spidermonkey 1.7 and probably
1.8
( I'm not sure what the other developers think about it? There was no
comment at all :/)
Vince has committed a change based on your patch.
Chris
12:44 a.m.
New subject: JavaScript
btw I apologise for some of my messages not threading properly.
Whenever I reply to Ole it crashes - looks like the message-id is too
long for this (ten years out of development) mailer, as it sends after
rebooting but with the end of the message-id in In-Reply-To chopped
off.
I'd ditch this mailer but I like the threading capability.
Just in case it was irritating anybody!
Chris
8:16 p.m.
New subject: JavaScript
On 1 Jul 2012 23:34:50 +0100, Chris Young wrote:
On Mon, 02 Jul 2012 00:01:40 +0200, Ole wrote:
> Almost yes, this patch is working for spidermonkey 1.7 and probably 1.8
> ( I'm not sure what the other developers think about it? There was no
> comment at all :/)
Vince has committed a change based on your patch.
There seems to be a couple of minor problems though. One is that the
JS_FS etc macros aren't in the NetSurf headers (I assume this is
intentional, and they can be easily added to the Spidermonkey includes
in any case)
The others are attached. I'm not sure if my changes break later
versions, given that I'm still testing on 1.5.
Chris
1:23 a.m.
New subject: JavaScript
Am Dienstag, den 03.07.2012, 20:16 +0200 schrieb "Chris Young"
<chris.young(a)unsatisfactorysoftware.co.uk>:
> Vince has committed a change based on your patch.
There seems to be a couple of minor problems though. One is that the
JS_FS etc macros aren't in the NetSurf headers (I assume this is
intentional, and they can be easily added to the Spidermonkey
includes
in any case)
The JS_FS_ etc. macros were already in my patch. I guess they didn't
made it into the repository
because there wasn't an additional #ifdef JS_VERSION <= 170
So, it's maybe worth a second try.
However, today I tried to build js-1.8 ( all I had found was an rc ).
1.8 is still the same
build system like 1.7, 1.4 etc. so porting it should be absolutely
straight.
The 1,8 rc js-console sadly crashes with an failing assert - this
doesn't happen when build under linux.
So, I still have to stick to js 1.7, except there is an 1.8 release
version around which fixes the bug.
I had a look at the debian squeeze iceweasel patches, but it contains a
lot of them.
So, finally I want to suggest that you also try to compile 1.7, it
would be better if we both
use the same "old" version. 1.7 should be easy to port. At least as
easy as 1.5. Then
we don't have to figure out difference between 1.5 and 1.7...
Is there anyone with big-endian and working spidermonkey 1.8 jsconsole?
I do not have problems when running
scripts directly, just when starting up the interactive jsconsole. It
happens during JS_NewObjectWithPrototype.
Greets,
Ole
1:38 a.m.
New subject: JavaScript
Am Dienstag, den 03.07.2012, 20:16 +0200 schrieb "Chris Young"
<chris.young(a)unsatisfactorysoftware.co.uk>:
The others are attached. I'm not sure if my changes break later
versions, given that I'm still testing on 1.5.
#define JSAPI_FS(name, nargs, flags) \
- JS_FS(#name, jsapi_native_##name, nargs, flags, 0)
+ JS_FS(#name, jsapi_native_##name, nargs, flags)
That should probably extended into something like that:
#ifdef JS_VERSION <= 150
JS_FS(#name, jsapi_native_##name, nargs, flags, 0)
#else
JS_FS(#name, jsapi_native_##name, nargs, flags)
( it looks like that 1.5 uses the same number of initial values
as versions > 1.8.0 )
#define JSString_to_char(injsstring, outchar, outlen) \
- txt = JS_GetStringBytes(u16_txt); \
+ txt = JS_GetStringBytes(injsstring); \
outlen = strlen(txt)
Confirmed, that part is also required for 1.8.0
Greets,
Ole
3914
days inactive
3916
days old
netsurf-dev@netsurf-browser.org
4 comments
2 participants
participants (2)
-
Chris Young -
Ole