1:50 p.m.
Somewhere in the last few revisions the treeview redraw has stopped
blanking the area it is redrawing first. Am I supposed to be blanking
the area in the frontend code, or is this a temporary glitch?
Chris
2:48 p.m.
New subject: r11058 tlsa - /trunk/netsurf/desktop/tree.c
In article
<OUT-4D090E13.MD-1.4.17.chris.young(a)unsatisfactorysoftware.co.uk>,
Chris Young <chris.young(a)unsatisfactorysoftware.co.uk> wrote:
Somewhere in the last few revisions the treeview redraw has stopped
blanking the area it is redrawing first. Am I supposed to be blanking
the area in the frontend code, or is this a temporary glitch?
Should work. Tested RISC OS and GTK (the only other front ends with
treeview support).
The only entry to tree redraw is tree_draw() in desktop/tree.c and the
first thing it does is plot a flat filled rectangle to the extents of the
requested clip region.
Actually I've just noticed that it's been doing that plot even before it
sets the clip rectangle though the plotters. I'll fix that in a second.
However, if that's the reason it's broken, it should have been broken
before, because it's been like that since the treeview branch.
--
Michael Drake (tlsa) http://www.netsurf-browser.org/
3:12 p.m.
New subject: r11058 tlsa - /trunk/netsurf/desktop/tree.c
On Wed, 15 Dec 2010 19:48:52 +0000 (GMT), Michael Drake wrote:
The only entry to tree redraw is tree_draw() in desktop/tree.c and
the
first thing it does is plot a flat filled rectangle to the extents of the
requested clip region.
Actually I've just noticed that it's been doing that plot even before it
sets the clip rectangle though the plotters. I'll fix that in a second.
However, if that's the reason it's broken, it should have been broken
before, because it's been like that since the treeview branch.
Well, it seems to have fixed it. I had noticed an issue previously
with overdrawing when nodes at the bottom of the tree were expanded -
and that seems to have gone now too.
Thanks!
Chris
3:39 p.m.
New subject: r11058 tlsa - /trunk/netsurf/desktop/tree.c
In article
<OUT-4D09214A.MD-1.4.17.chris.young(a)unsatisfactorysoftware.co.uk>,
Chris Young <chris.young(a)unsatisfactorysoftware.co.uk> wrote:
Well, it seems to have fixed it.
Good. :)
I had noticed an issue previously with overdrawing when nodes at the
bottom of the tree were expanded - and that seems to have gone now too.
Yeah, it's working properly now. The only reason it would have nearly
worked before was because of redundant rectangle plots under each piece of
text, which I removed in one of my recent changes. There wasn't anything
filling under the tree furniture (except the background fill that was
broken for AmigaOS).
--
Michael Drake (tlsa) http://www.netsurf-browser.org/
4554
days inactive
4554
days old
netsurf-dev@netsurf-browser.org
3 comments
2 participants
participants (2)
-
Chris Young -
Michael Drake