6:55 p.m.
Hello,
currently !NetSurf stores its font cache in Wimp$Scrap.
When Wimp$Scrap is copied to a RAMDisc on boot this might lead to
problems, because naturally the content of Wimp$Scrap is not copied
back to disk when the system is shut down. Hence RUfl_Cache would be
recreated on every first start after boot.
IMHO a file that should be kept permanently should not be put in the
Scrap-folder.
We just discussed this issue during a RISC OS user meeting, and a
better approach seems to be to place RUfl_Cache in
<Choices$Write>.WWW.NetSurf.
Please find attached two patches that change the source accordingly.
netsurf-riscos-scripts-Run.patch adds a new Variable NetSurf$RUflCache
in ./netsurf/riscos/scripts/Run.
librufl-src-rufl_internal.patch adjusts rufl_CACHE in
./librufl/src/rufl_internal.h accordingly.
Opinions?
Cheers,
Christian Walther
5:07 a.m.
On Sun, Jul 19, 2015 at 12:55:06AM +0200, Christian Walther wrote:
Hello,
currently !NetSurf stores its font cache in Wimp$Scrap.
When Wimp$Scrap is copied to a RAMDisc on boot this might lead to
problems, because naturally the content of Wimp$Scrap is not copied
back to disk when the system is shut down. Hence RUfl_Cache would be
recreated on every first start after boot.
IMHO a file that should be kept permanently should not be put in the
Scrap-folder.
IMHO you shouldn't put !Scrap in a RAM disc :)
We just discussed this issue during a RISC OS user meeting, and a
better approach seems to be to place RUfl_Cache in
<Choices$Write>.WWW.NetSurf.
No, it's not choices data. Putting it !Cache is probably a better idea,
if it is available.
B.
6:47 a.m.
New subject: Patch proposal for RISC OS: Store RUfl_Cache in Choices$Write instead of Wimp$Scrap
On 19 Jul, Rob Kendrick wrote in message
<20150719090731.GB27726(a)platypus.pepperfish.net>:
On Sun, Jul 19, 2015 at 12:55:06AM +0200, Christian Walther wrote:
> We just discussed this issue during a RISC OS user meeting, and a better
> approach seems to be to place RUfl_Cache in <Choices$Write>.WWW.NetSurf.
No, it's not choices data. Putting it !Cache is probably a better idea,
if it is available.
I'd agree.
The patch as sumbitted is also broken, as it will cause RUfl to *read* data
from Choices$Write.
--
Steve Fryatt - Leeds, England
http://www.stevefryatt.org.uk/
9:07 a.m.
Hi,
thank you for your feedback.
The reason for putting !Scrap in a Ramdisk seems to be some
performance benefit for certain workloads or use cases. !MiscSetup
makes this easy by copying !Scrap automatically during boot.
I didn't use this setup myself, but for some people it seems to be an
issue, and I thought that this might be a good start to become more
familiar with RISC OS programming.
2015-07-19 12:47 GMT+02:00 Steve Fryatt <lists(a)stevefryatt.org.uk>:
On 19 Jul, Rob Kendrick wrote in message
<20150719090731.GB27726(a)platypus.pepperfish.net>:
> On Sun, Jul 19, 2015 at 12:55:06AM +0200, Christian Walther wrote:
>
> > We just discussed this issue during a RISC OS user meeting, and a better
> > approach seems to be to place RUfl_Cache in <Choices$Write>.WWW.NetSurf.
>
> No, it's not choices data. Putting it !Cache is probably a better idea,
> if it is available.
I'd agree.
Sounds reasonable.
The patch as sumbitted is also broken, as it will cause RUfl to
*read* data
from Choices$Write.
I rewrote the patch to reflect your suggestions. It checks if
Cache$Dir is set and either sets NetSurf$RUflCacheDir to
<Wimp$ScrapDir> or <Cache$Dir>.NetSurf
rufl_internal.h is patched to make use of <NetSurf$RUflCacheDir> and
hardcodes RUfl_Cache as filename.
Cheers
Christian Walther
2867
days inactive
2871
days old
netsurf-dev@netsurf-browser.org
3 comments
3 participants
participants (3)
-
Christian Walther -
Rob Kendrick -
Steve Fryatt