On Sat, Jun 30, 2012 at 01:20:01PM +0200, Ole wrote: You have completely missed whats going on here, the code there is correct. let me explain: The whole browser has a single library instance known as the "runtime" created with JS_NewRuntime(). Each browsing context, as defined by the DOM (in our case a browser window - NOT to be confused with the javascript window object - they are related but not the same) has a separate javascript context created upon teh runtime with JS_NewContext() The lifetime of this context is directly coupled to the browser window, though I have arranged delaying the creation of the context untill the first time a fresh javascript global is created. Creating new contexts is a relatively expensive operation so it is worth delaying it as long as possible. The next component is the global object, this is the javascript "window" object within a browser to which all the other browser context is attached (document, console etc. etc.) it is created with JS_NewCompartmentAndGlobalObject(). The global is created within a context. The global javascript object (and its container if supported) is created afresh when a root content (the content which is caused to be loaded by navigating to a new page in the browser window) aquires the context from its containig browser window. The loading content only does this once when it initialy comes across a resource (script tag) which requires it to use the javascript engine (as a side effect, if a page never uses javascript it will never ask the browser window for a context and we avoid the overhead of creating a fresh global). The content *must* be given a fresh global object or the content will not be starting from the state the previously loaded page left it! complete with pointers to the previous DOM tree etc. The spidermonky authors indicated that from the 1.8 series onwards the global object is garbage collected when replaced and I did not need to perform any additional housekeeping. I suspect that previous editions may need the user to explicitly mark the global as ready for destruction before it is replaced. This should be put in as JS_VERSION conditional code within jsapi.h which implements JS_NewCompartmentAndGlobalObject() -- Regards Vincent http://www.kyllikki.org/

Am Samstag, den 30.06.2012, 14:10 +0200 schrieb Vincent Sanders <vince(a)netsurf-browser.org&gt;: I have created a GIT branch and added a few lines for GC the old global object. I would be happy if there is some other person who can review this. The old docs say, that the global object is rooted. So I though calling JS_RemoveRoot is the right thing to do. I did not call GC explicitly and setting the global object to NULL afterward is mandatory. Here is the branch patch: http://git.netsurf-browser.org/?p=netsurf.git;a=blobdiff;f=javascript/jsa... Sorry, I don't know how to diff agains master, yet. Sorry, the next time I will submit such thing as an diff file. Greets, Ole

On Tue, Jul 03, 2012 at 09:59:14AM +0100, Daniel Silverstone wrote: Will this be described in the idiot's guide to git that you're creating for us? B.