Hi Michael.
Thanks for the review of the surface. I have fixed the issues you mentioned.
It just seems better to stick to the Netsurf code style as much as possible.
The revise file is attached to this mail. It can also be found on github[1].
> static int kolibri_surface_claim(nsfb_t *nsfb, nsfb_bbox_t *box)
> {
> /* TODO: Convert to full function from stub */
>
> /*
> if ((cursor != NULL) &&
> (cursor->plotted == true) &&
> (nsfb_plot_bbox_intersect(box, &cursor->loc))) {
> nsfb_cursor_clear(nsfb, cursor);
> }
> */
>
> return 0;
> }
The framebuffer front end normally renders its own mouse pointer.
From this, I guess you're relying on the pointer from the KolibriOS desktop.
This should work for the most part, but I'm not sure you'll be able to
do things like make the pointer change shape when hovering over a link
unless we extend the nsfb surface API.
This isn't high priority (or even required) atm, so I think It's best
to let the stub remain for a future maintainer (possibly myself) in
the hopes that it will be eventually fixed.
I'll wait for Vince's opinion on this.
Once that's done and I get Netsurf git access, I'll start moving the code.
Thank you, everyone!
Regards,
Ashish Gupta
[1] :
https://github.com/ashmew2/nskolibrios/blob/nskolibrios/libnsfb/src/surfa...