7:48 a.m.
Hello,
As I posted earlier, I wanted to submit patches for the Makefile to
support the FreeMiNT OS.
No one responded to my questions, so here is my patch. Please tell me if
there is something wrong.
Heres the description of the patch:
Added specific LDFLAGS for MiNT in framebuffer target. (I know that
Makefile.config is the first place to make additions, but Makefile.config
can't be used for LDFLAGS)
Also added MiNT specific CFLAGS to the framebuffer target part.
Added an new target called mint when host == mint and the target is not
set.
I would be really nice if someone could integrate this into SVN, or let me
know why the patch is rejected.
Greets,
Ole
5:42 p.m.
On Sun, 2010-06-20 at 00:48 +0200, m0n0 wrote:
Heres the description of the patch:
Added specific LDFLAGS for MiNT in framebuffer target. (I know that
Makefile.config is the first place to make additions, but Makefile.config
can't be used for LDFLAGS)
It can, but that's not much use if you want it to build without
modification from SVN or a release tarball.
Added an new target called mint when host == mint and the target is
not
set.
I don't see this in your patch.
Can you explain this, please?:
+ LDFLAGS += -lSDL -lldg -lgem -lm
J.
8:57 p.m.
Hello,
Am Sonntag, den 20.06.2010, 10:42 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
> Added an new target called mint when host == mint and the target
is not
> set.
I don't see this in your patch.
Yes you are right, it's missing. I attached a new patch. It now adds a new
valid default target for mint ( which is not implemented yet ).
Can you explain this, please?:
+ LDFLAGS += -lSDL -lldg -lgem -lm
On MiNT only SDL framebuffer backend is available. (Altough there is an
old X11 version available for MiNT. If someone really want to use that X11
with MiNT/Netsurf he/she should figure it out how to adjust the makefile.)
-lSDL -lgem is needed for SDL.
I've seen that the -lldg entry isn't really needed. I removed that entry
within the attached patch.
-lm is needed for the math function, If it's missing the compiler (gcc 4.3
and 4.5 are available for MiNT systems) complaints about undefined
references to the math functions.
On 19.06.10, you wrote:
I know not much of netsurf buildsystem, so i a have avoid to answer
early, but the amiga OS Version
need
no makefile changes.only makefile.config need modify.
I understood it that way: the Makefile.config LDFLAGS would be prepended
before the framebuffer target LDFLAGS, that's is not acceptable for my
changes. Anyway, the configuration of the LDFLAGS through pkg-config within
the framebuffer part spits out errors when used for packages which do not
provide an pkg-config file, these errors are passed along...
Thanks to all of you for having a closer look at the file!
Greets,
Ole
1:13 a.m.
On Sun, 2010-06-20 at 13:57 +0200, m0n0 wrote:
Hello,
Am Sonntag, den 20.06.2010, 10:42 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
>> Added an new target called mint when host == mint and the target is not
>> set.
>
> I don't see this in your patch.
Yes you are right, it's missing. I attached a new patch. It now adds a new
valid default target for mint ( which is not implemented yet ).
I'd prefer it if you just defaulted it to the framebuffer, if that's all
that works. You can add mint properly when there's some likelihood that
there's a frontend that builds.
> Can you explain this, please?:
>
> + LDFLAGS += -lSDL -lldg -lgem -lm
On MiNT only SDL framebuffer backend is available. (Altough there is an
old X11 version available for MiNT. If someone really want to use that X11
with MiNT/Netsurf he/she should figure it out how to adjust the makefile.)
-lSDL -lgem is needed for SDL.
Surely these are pulled in by libnsfb's dependency on SDL (as specified
in libnsfb's pkg config file)?
J.
2:13 a.m.
Am Sonntag, den 20.06.2010, 18:13 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
> -lSDL -lgem is needed for SDL.
Surely these are pulled in by libnsfb's dependency on SDL (as
specified
in libnsfb's pkg config file)?
I'm not really sure what you mean by asking that...
But after having a closer look, I see that I also patched the pkg-config
file for libnsfb. So that it does not requires xcb and such things.
But it just contains -lnsfb as Linker configuration. So -lSDL is really
needed later.
I'll have a look on how the libnsfb.pc.in is created, then I will provide
another patch for that issue.
Thanks & Greets,
Ole
2:43 a.m.
On Sun, 2010-06-20 at 19:13 +0200, m0n0 wrote:
Am Sonntag, den 20.06.2010, 18:13 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
>> -lSDL -lgem is needed for SDL.
> Surely these are pulled in by libnsfb's dependency on SDL (as specified
> in libnsfb's pkg config file)?
I'm not really sure what you mean by asking that...
But after having a closer look, I see that I also patched the pkg-config
file for libnsfb. So that it does not requires xcb and such things.
But it just contains -lnsfb as Linker configuration. So -lSDL is really
needed later.
It requires SDL (and the X libraries), thus:
Requires: sdl xcb xcb-icccm xcb-image xcb-keysyms
which, on most systems results in "pkg-config --libs libnsfb" including
those libraries and their dependencies. Therefore, -lSDL should not be
needed in your Makefile changes.
What does pkg-config --libs libnsfb produce on your system?
J.
2:46 a.m.
Am Sonntag, den 20.06.2010, 19:13 +0200 schrieb m0n0 <ole(a)monochrom.net>:
Am Sonntag, den 20.06.2010, 18:13 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
I'll have a look on how the libnsfb.pc.in is created, then I will
provide
another patch for that issue.
Actually, I think it's complicated for me to add that. I tried to set
REQUIRED_PKGS,
because Makefile.top describes this as an Input Variable that describes
the Requires: line in the libnsfb.pc.in file. But that does not work. It
always puts xcb and xcccb-image etc. into the pkg-config file. ( or maybe
these items are not replaced).
Greets,
Ole
3:19 a.m.
Am Sonntag, den 20.06.2010, 19:43 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
What does pkg-config --libs libnsfb produce on your system?
Ok, I got it. After patching away the X requires, it outputs -lSDL -lgem
-lldg
But unpatched it hast just gave an error. That has made me think I have to
add these lines manually.
I'll removed these things and will provide the updated patches later.
Can someone explain how to adjust the dependencies in the libnsfb.pc file?
Greets,
Ole
5:15 a.m.
Am Sonntag, den 20.06.2010, 19:43 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
It requires SDL (and the X libraries), thus:
Requires: sdl xcb xcb-icccm xcb-image xcb-keysyms
which, on most systems results in "pkg-config --libs libnsfb" including
those libraries and their dependencies. Therefore, -lSDL should not be
needed in your Makefile changes.
What does pkg-config --libs libnsfb produce on your system?
I removed the -lSDL -lgem line. Updated patch attached.
I also set the default mint target to framebuffer.
Sorry for the failures.
Greets,
Ole
4:26 p.m.
On Sun, 2010-06-20 at 22:15 +0200, m0n0 wrote:
Am Sonntag, den 20.06.2010, 19:43 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
> It requires SDL (and the X libraries), thus:
>
> Requires: sdl xcb xcb-icccm xcb-image xcb-keysyms
>
> which, on most systems results in "pkg-config --libs libnsfb" including
> those libraries and their dependencies. Therefore, -lSDL should not be
> needed in your Makefile changes.
>
> What does pkg-config --libs libnsfb produce on your system?
I removed the -lSDL -lgem line. Updated patch attached.
I also set the default mint target to framebuffer.
I've committed a modified version of this as r10578.
Thanks!
J.
4:28 p.m.
On Sun, 2010-06-20 at 19:46 +0200, m0n0 wrote:
Am Sonntag, den 20.06.2010, 19:13 +0200 schrieb m0n0
<ole(a)monochrom.net>:
> Am Sonntag, den 20.06.2010, 18:13 +0200 schrieb John-Mark Bell
> <jmb(a)netsurf-browser.org>:
> I'll have a look on how the libnsfb.pc.in is created, then I will
provide
> another patch for that issue.
Actually, I think it's complicated for me to add that. I tried to set
REQUIRED_PKGS,
because Makefile.top describes this as an Input Variable that describes
the Requires: line in the libnsfb.pc.in file. But that does not work. It
always puts xcb and xcccb-image etc. into the pkg-config file. ( or maybe
these items are not replaced).
They aren't replaced, as libnsfb doesn't currently use the buildsystem's
ability to generate pkg-config Requires declarations. Its requirements
are currently hard-coded.
J.
6:50 p.m.
Am Montag, den 21.06.2010, 09:26 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
I've committed a modified version of this as r10578.
Thanks!
Thanks, too!
I also posted some patches for libnsfb. I'm off for vaction now, so I
can't make changes to that patch in that time, but I'm back in about a
week.
Greets,
Ole
4842
days inactive
4844
days old
netsurf-dev@netsurf-browser.org
11 comments
2 participants
participants (2)
-
John-Mark Bell -
m0n0