Here are the results of my review. I mainly concentrated on looking for bugs, and mostly ignored efficiency and style. render/html.c - ok render/textplain.c - ok render/html_redraw.c - ok render/html.h - ok render/layout.c - ok render/favicon.c memory leak: + if (strcasecmp(rel, "apple-touch-icon") == 0) + continue; change to: + if (strcasecmp(rel, "apple-touch-icon") == 0) { + xmlFree(rel); + continue; + } render/favicon.h - ok image/ico.c - ok image/ico.h - ok framebuffer/fb_search.c - ok (stubs) gtk/gtk_gui.h - ok gtk/options.h - ok gtk/gtk_save.c - comment wrong (no argument c): +* \param sourcedata pointer to data to save, NULL when all data in c gtk/gtk_history.c - ok gtk/gtk_theme.c - nsgtk_theme_verify() memory leak: + if (testfile == NULL) { + warn_user(messages_get("NoMemory"), 0); + return false; + } add: free(filecontent); gtk/gtk_toolbar.c - ok gtk/gtk_menu.c nsgtk_menu_file_menu(), nsgtk_menu_edit_menu(), nsgtk_menu_view_menu(), nsgtk_menu_nav_menu(), nsgtk_menu_tabs_menu(), nsgtk_menu_help_menu(), nsgtk_menu_export_submenu(), nsgtk_menu_scaleview_submenu(), nsgtk_menu_images_submenu() nsgtk_menu_toolbars_submenu(), nsgtk_menu_debugging_submenu() add free(ret) before 2nd "return NULL;" gtk/gtk_search.c - ok gtk/gtk_download.c - ok gtk/gtk_theme.h - ok gtk/gtk_toolbar.h - ok gtk/gtk_window.c - ok gtk/gtk_menu.h - ok gtk/gtk_search.h - ok gtk/sexy_icon_entry.c - didn't review gtk/sexy_icon_entry.h - didn't review gtk/gtk_window.h - ok gtk/gtk_scaffolding.h - ok gtk/gtk_scaffolding.c MULTIHANDLER(savepage): add g_free(path) before "return TRUE;" inside "if (d == NULL)" gtk/gtk_tabs.c - ok gtk/dialogs/gtk_about.c - ok gtk/dialogs/gtk_options.h - ok gtk/dialogs/gtk_options.c - ok gtk/dialogs/gtk_source.c nsgtk_source_tab_init() - needs free(ndata); gtk/gtk_login.c - ok gtk/gtk_gui.c - ok gtk/gtk_selection.c - ok beos/beos_search.cpp - ok beos/beos_scaffolding.cpp - ok utils/utils.c - ok utils/utils.h - ok utils/config.h - ok utils/container.c container_extract_theme() - add free(themename) before 3rd return utils/container.h - ok riscos/gui.c - ok riscos/gui.h - ok riscos/save.c - ok riscos/search.c - ok riscos/window.c - ok riscos/menus.c - ok desktop/options.h - ok desktop/options.c - ok desktop/searchweb.c search_web_get_url() - add free(pref) before 2nd return desktop/searchweb.h - enum search_providers seems unnecessary - values never used - why not int? desktop/browser.c - ok desktop/browser.h - ok desktop/search.c - ok desktop/search.h - ok desktop/save_complete.c - ok desktop/save_complete.h - ok desktop/gui.h - ok content/fetch.h - ok content/fetchers/fetch_curl.c - ok content/fetchers/fetch_data.c - ok content/fetch.c - ok content/content.c - ok content/fetchcache.c - ok amiga/fetch_file.c - ok amiga/menu.c - ok amiga/download.c - ok amiga/gui.c - ok amiga/save_complete.c - ok amiga/gui.h - ok amiga/search.c - ok -- James Bursa, NetSurf developer http://www.netsurf-browser.org/