2:40 a.m.
Hello there,
because I'm using an newer version of freetype2, I use this patch to
compile font_freetype.c, than I add
-DFREETYPE_VERSION=20312 to the CFLAGS in Makefile.config
What do developers think about it? How would you do it, is this good
enough to merge it into the trunk?
Greets,
Ole
5:13 a.m.
On Wed, 2010-06-30 at 19:40 +0200, m0n0 wrote:
Hello there,
because I'm using an newer version of freetype2, I use this patch to
compile font_freetype.c, than I add
-DFREETYPE_VERSION=20312 to the CFLAGS in Makefile.config
No, this is not the correct approach. If you need to detect the version
of freetype in use, include FT_FREETYPE_H and conditionalise on the
values of FREETYPE_MAJOR, FREETYPE_MINOR, and FREETYPE_PATCH.
In this case, even this is unnecessary. The correct fix is to include
the freetype headers in the way expected by freetype. This is what I
have done in r10591.
J.
5:29 a.m.
Am Mittwoch, den 30.06.2010, 22:13 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
No, this is not the correct approach. If you need to detect the
version
of freetype in use, include FT_FREETYPE_H and conditionalise on the
values of FREETYPE_MAJOR, FREETYPE_MINOR, and FREETYPE_PATCH.
I believed including ft2build.h is only okay for newer versions of
freetype and I didn't wanted to break compatibility with the old versions.
In this case, even this is unnecessary. The correct fix is to
include
the freetype headers in the way expected by freetype. This is what I
have done in r10591.
Thanks,
Ole
6:22 a.m.
On Wed, 2010-06-30 at 22:29 +0200, m0n0 wrote:
Am Mittwoch, den 30.06.2010, 22:13 +0200 schrieb John-Mark Bell
<jmb(a)netsurf-browser.org>:
> No, this is not the correct approach. If you need to detect the version
> of freetype in use, include FT_FREETYPE_H and conditionalise on the
> values of FREETYPE_MAJOR, FREETYPE_MINOR, and FREETYPE_PATCH.
I believed including ft2build.h is only okay for newer versions of
freetype and I didn't wanted to break compatibility with the old versions.
We were already including ft2build.h from font_freetype.h. Therefore,
it's perfectly fine to use that mechanism in font_freetype.c, too. I
don't think we've ever supported a version of freetype that pre-dates
the introduction of ft2build.h.
J.
4834
days inactive
4834
days old
netsurf-dev@netsurf-browser.org
3 comments
2 participants
participants (2)
-
John-Mark Bell -
m0n0