As most of you know I have been discussing cleaning up the plotter API with respect to the bitmap operations with a view to adding a bitmap cache in future. The first stage of this is to rationalize the bitmap operation to a *single* call with flags and to remove the passing around of content objects into plotters. This has the pleasant side effect of improving cache locality and reducing the number of parameters to seven for the tiled case, which means GCC stops spilling *all* the parameters to stack. Performance wise this cleanup has pretty much zero cost. However my updates to each frontends plotters are somewhat naive and using direct bitops on the flags instead of converting to a bool (I wanted least change) results in an improvement. I have altered *all* frontend plotters but have only been able to compile and run on framebuffer and gtk, can someone please at least compile risc os, amiga and beos? There is a single "regression" from this alteration which is that the pdf save exporter will not currently directly embed the original jpegs into pdf...has anyone actually tested this with a modern haru? I have, its broken anyway! I do intend to fix this but as a seperate piece of work to make our haru handling less explody. patch attached, I will commit this later today unless there are strong objections. amiga/plotters.c | 37 ++++++-------- amiga/plotters.h | 4 - beos/beos_plotters.cpp | 53 +++++++------------- desktop/history_core.c | 2 desktop/knockout.c | 103 +++++++++------------------------------- desktop/plotters.h | 9 +-- desktop/save_pdf/pdf_plotters.c | 73 ++++++++-------------------- framebuffer/framebuffer.c | 53 ++++++++++---------- framebuffer/gui.h | 11 ---- gtk/gtk_plotters.c | 49 +++++++------------ gtk/gtk_print.c | 48 +++++++----------- image/bmp.c | 16 ++++-- image/gif.c | 14 ++++- image/ico.c | 16 ++++-- image/jpeg.c | 13 +++-- image/mng.c | 12 +++- image/png.c | 25 +++++---- image/rsvg.c | 2 riscos/plotters.c | 57 ++++++++-------------- 19 files changed, 249 insertions(+), 348 deletions(-) -- Regards Vincent http://www.kyllikki.org/