4:44 p.m.
I've made some changes to the RISC OS front-end to partly address tickets
#390 and #2053: URL entry fields are now 2047 characters long (which appears
to be up there with the "best of the worst" of the mainstream browsers), and
changing this is now a case of altering a #define in riscos/gui.h and
recompiling. It's a compromise, as RISC OS's inability to change the size of
writable fields on the fly means that longer sizes waste more memory for
each window that's opened.
In addition, over-size URLs are handled more gracefully by browser toolbars:
the user gets a warning and the field is cleared and terminated safely.
Finally, I've fixed a bug where it was possible for toolbar URLs to miss the
conversion from UTF8 into local encoding under some (probably unlikely)
circumstances.
If anyone has any thoughts about the advisability (or otherwise) of these
changes, I'd welcome comments. Otherwise, they are in the branch
http://git.netsurf-browser.org/netsurf.git/log/?h=stevef/urlsize
if someone with access outside of riscos/ could merge them with the master?
There's a new message token in FatMessages, which could do with the non-en
forms translating into appropriate languages: xx.ro.LongURL is the warning
the user gets of URLs which are too long to display.
PS: Should I be deleting my branches once they're merged? If so, what's the
preferred way to do it?
--
Steve Fryatt - Leeds, England
http://www.stevefryatt.org.uk/
1:01 p.m.
On Sun, Jan 26, 2014 at 15:44:17 +0000, Steve Fryatt wrote:
PS: Should I be deleting my branches once they're merged? If so,
what's the
preferred way to do it?
Yes, an easy way to tell if your branches on the server have been merged is:
git checkout origin/master (this detaches you but it's okay)
git branch -r --merged
git checkout mybranchname
Any of the merged branches which are yours can be removed with:
git push --delete origin branchname
e.g.
git push --delete origin stevef/mad-riscos-badgers
D.
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
12:51 a.m.
On 30 Jan, Daniel Silverstone wrote in message
<20140130120127.GK26047(a)somnambulist.local>:
On Sun, Jan 26, 2014 at 15:44:17 +0000, Steve Fryatt wrote:
> PS: Should I be deleting my branches once they're merged? If so, what's
> the preferred way to do it?
Yes, [...]
Thanks -- I've tidied up after myself now.
--
Steve Fryatt - Leeds, England
http://www.stevefryatt.org.uk/
7:49 p.m.
On Thu, Jan 30, 2014 at 11:51:34PM +0000, Steve Fryatt wrote:
On 30 Jan, Daniel Silverstone wrote in message
<20140130120127.GK26047(a)somnambulist.local>:
> On Sun, Jan 26, 2014 at 15:44:17 +0000, Steve Fryatt wrote:
>
> > PS: Should I be deleting my branches once they're merged? If so,
what's
> > the preferred way to do it?
>
> Yes, [...]
Thanks -- I've tidied up after myself now.
I merged your menus branch again, so assuming the merge was correct
you can remove that too.
--
Regards Vincent
http://www.kyllikki.org/
3:07 p.m.
On 31 Jan, Vincent Sanders wrote in message
<20140131184930.GE31163(a)kyllikki.org>:
On Thu, Jan 30, 2014 at 11:51:34PM +0000, Steve Fryatt wrote:
> On 30 Jan, Daniel Silverstone wrote in message
> <20140130120127.GK26047(a)somnambulist.local>:
>
> > On Sun, Jan 26, 2014 at 15:44:17 +0000, Steve Fryatt wrote:
> >
> > > PS: Should I be deleting my branches once they're merged? If so,
> > > what's the preferred way to do it?
> >
> > Yes, [...]
>
> Thanks -- I've tidied up after myself now.
I merged your menus branch again, so assuming the merge was correct you
can remove that too.
I was intending to still work on it a bit more: carefully reading the code
to understand what was going on with the gui_poll() issue turned up a few
things that look completely wrong (in the "probably don't even work"
sense),
so I'd intended to fix those in the branch (or document why they were
correct all along) and make sure that I was happy with everything before
merging it all back in.
I don't think there should be issues with the second set of changes you've
merged, though -- and if there are, I'm sure someone will let me know fairly
soon. :-)
--
Steve Fryatt - Leeds, England
http://www.stevefryatt.org.uk/
3:20 p.m.
On Sat, Feb 01, 2014 at 02:07:46PM +0000, Steve Fryatt wrote:
On 31 Jan, Vincent Sanders wrote in message
<20140131184930.GE31163(a)kyllikki.org>:
> On Thu, Jan 30, 2014 at 11:51:34PM +0000, Steve Fryatt wrote:
> > On 30 Jan, Daniel Silverstone wrote in message
> > <20140130120127.GK26047(a)somnambulist.local>:
> >
> > > On Sun, Jan 26, 2014 at 15:44:17 +0000, Steve Fryatt wrote:
> > >
> > > > PS: Should I be deleting my branches once they're merged? If so,
> > > > what's the preferred way to do it?
> > >
> > > Yes, [...]
> >
> > Thanks -- I've tidied up after myself now.
>
> I merged your menus branch again, so assuming the merge was correct you
> can remove that too.
I was intending to still work on it a bit more: carefully reading the code
to understand what was going on with the gui_poll() issue turned up a few
things that look completely wrong (in the "probably don't even work"
sense),
so I'd intended to fix those in the branch (or document why they were
correct all along) and make sure that I was happy with everything before
merging it all back in.
oops, premature merge...
I don't think there should be issues with the second set of changes you've
merged, though -- and if there are, I'm sure someone will let me know fairly
soon. :-)
yeah, thanks to the wonders of git you can just keep on going then,
let me know if you need me to merge, though of course you should be ok
to do that yourself for anything riscos ish.
--
Regards Vincent
http://www.kyllikki.org/
3588
days inactive
3594
days old
netsurf-dev@netsurf-browser.org
5 comments
3 participants
participants (3)
-
Daniel Silverstone -
Steve Fryatt -
Vincent Sanders