In article <f0f413440807271507o5f507fbcj5fe949cbff58585c(a)mail.gmail.com&gt;, Adam Blokus <adamblokus(a)gmail.com&gt; wrote: I like the progress so far. It would be good to work on improving the output so it works better with more PDF viewers, I think. http://www.smoothartist.com/netsurf/nspdf.png That shows some of the issues I'm seeing. At the top, there is a blue box under the "NetSurf" logo and the search box. This is just one box in the HTML, but in the output it shows that it is segmented into several rectangles. This is because of "knockout rendering", which was created to optimise screen redraw. It shouldn't really be used for printing or PDF export, so I think making them bypass the knockout rendering would improve the output. Maybe you could edit the content redraw handlers to take a parameter saying you're printing (or exporting in a vector format like PDF). Then you can avoid knockout_plot_start() and knockout_plot_end() if printing in html_redraw(). You can also avoid the text decoration "anti-aliasing" that's done in html_redraw_text_decoration(), which is intended only for screen redraw. (That's why underlines don't have the same blue colour as the link text.) Also, on the screenshots, the underline on the text "RISC OS" goes to the end of the paragraph, but it should only underline "RISC OS". The screenshot bitmap is not centered properly in its box, it's too far to the left. I'm not really sure what causes the stripes on the navigation bar, but it looks like there could be an off-by-one error in the pdf plotter somewhere as the thin 1px borders around the navigation links don't always show up. The download box obviously has miss-positioned corners and missing logo and arrow images. All of these images are created as background images in CSS positioned boxes, so they use the tiled redraw plotter. http://www.smoothartist.com/netsurf/nspdfro.png That image shows a PDF exported on RISC OS. As you can see the paragraph is split over far too many lines. I'm not sure what causes this. Could the pdf/ directory be moved and renamed to desktop/save_pdf/ ? That would match the rest of the source better. Also is the stuff in testres/ required for anything? It would be good to either delete it or move it into http://source.netsurf-browser.org/trunk/netsurftest/ which is where the test resources are kept. Anyway, I think the progress has been excellent so far. :) Best regards, Michael -- Michael Drake (tlsa) http://www.netsurf-browser.org/

In article <f0f413440807271507o5f507fbcj5fe949cbff58585c(a)mail.gmail.com&gt;, Adam Blokus <adamblokus(a)gmail.com&gt; wrote: I think having those options where they are is fine. I'd only move the options to a dialogue that shows up each time an export is performed if you also implement a preview thing. So you could see visually how the options affect the page layout. About the options themselves: + I'd use the same default directory that is configured for downloads, and remove the default directory option from the Export section. + After a clean install, the Scale option defaults to 0%, which means that all PDFs show up completely blank. Clicking on the "Default" button sets it to 70%, which works. It should be given the 70% value initially. + The units for margins is currently 'px', which does not make much sense for paper or print. I'd change the units to 'cm' or 'in'. + The default filename for saved PDFs is currently 'out.pdf'. You should use the url_nice() function to give you a nice filename from the URL. Set it to strip extensions, because you'll be adding '.pdf' to the end. -- Michael Drake (tlsa) http://www.netsurf-browser.org/