Re: Review: Content factory
On Wed, 2011-05-04 at 23:01 +0000, John Tytgat wrote:
In message <E1QHjgy-0001se-E1@duiker>
John-Mark Bell <jmb(a)netsurf-browser.org> wrote:
> Index: render/html_internal.h
> ===================================================================
> --- /dev/null 2009-04-16 19:17:07.000000000 +0100
> +++ render/html_internal.h 2011-05-04 22:29:08.000000000 +0100
> @@ -0,0 +1,103 @@
> [...]
> +#ifndef _NETSURF_RENDER_HTML_INTERNAL_H_
> +#define _NETSURF_RENDER_HTML_INTERNAL_H_
^
Micro comment : plz do not use preprocessor defines starting with
underscore (and followed by a capital). A user program shouldn't use
those.
Fixed, though there are about 50 other headers with the same issue.
J.