got it now, it was that wndPreferences is not global at all, it should
have been a reference to dlg
Now it works perfectly [I hope!]
As for patching it parallel to the down-arrow history patch, the only
change I have made to netsurf.glade is to tick the checkbox for toolbar
style in toolbar->properties->general, so it would be possible to
manually modify a glade file to do that. The modifications to
options.glade are of course more in-depth, both are in the full diff
file, neither in the noglade diff file
Best
Mark
http://www.halloit.com
Key ID 046B65CF
Mark wrote:
So now I've tidied up the functions, solved the question of
whether to
consult global gtk preferences, introduced consistency between the windows;
However the gtk bug is relatively intractable, I've located its source,
I see that there is need at some stage to improve the consistency of the
preferences windows; what I'm seeing makes me feel the cause of the bugs
is that there is one preferences window per main window[scaffold], so
that the preferences for window N°1, say, are unaffected when you make
changes in the preferences opened from window N°2, then close window
N°2; the gtk bug appears as it looks as though there is 1 global handle
for the preferences windows, wndPreferences, so that when the
preferences window for window N°2 is destroyed [when window N°2 itself
is closed] then there is no 'proper' handle for the preferences window
for window N°1 [that was merely hidden, not destroyed, so is not
re-created afresh]
As I say, it needs looking into in more detail though for now it looks
as though it's worthwhile adding the patch as the bug is not
specifically linked to the patch
Best
Mark
http://www.halloit.com
Key ID 046B65CF