Re: Returning NULL from gui_download_window_create causes crash

Hi all I've found another stop/abort type crash :( Returning NULL from gui_download_window_create causes NetSurf to crash, rather than just aborting the pending download. Logs attached. Stack trace line numbers: 9.Files:Projects/netsurf_svn/netsurf> a2l netsurf-cairo 753a0 desktop/download.c:274 9.Files:Projects/netsurf_svn/netsurf> a2l netsurf-cairo 751b0 desktop/download.c:206 9.Files:Projects/netsurf_svn/netsurf> a2l netsurf-cairo 569bc content/llcache.c:1476 9.Files:Projects/netsurf_svn/netsurf> a2l netsurf-cairo 5474c content/llcache.c:314 9.Files:Projects/netsurf_svn/netsurf> a2l netsurf-cairo 531d0 content/hlcache.c:183 Crash log for task "netsurf-cairo" Generated by GrimReaper 53.2 Crash occured in module kernel at address 0x01414890 Type of crash: unknown exception Register dump: GPR (General Purpose Registers): 0: 00000021 59F83770 00000000 0140BA7C 81000009 00000000 01416A94 01C997C4 8: 81000000 0140BA7C 00000001 0141487C 0000015C 560E8C20 00000000 00000000 16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 24: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 FPR (Floating Point Registers, NaN = Not a Number): 0: nan 0 25 0 4: 0 1023.8 30.8 0 8: 0 128 1023.8 30.8 12: 1024 56 0 0 16: 0 0 0 0 20: 0 4.34638e-311 0 0 24: 0 0 0 -2.97403e+284 28: 0 0 0 -2.27896e+193 FPSCR (Floating Point Status and Control Register): 0x82004000 SPRs (Special Purpose Registers): Machine State (msr) : 0x0002F030 Condition (cr) : 0x24422044 Instruction Pointer (ip) : 0x01414890 Xtended Exception (xer) : 0x00000008 Count (ctr) : 0x0141487C Link (lr) : 0x0162A224 DSI Status (dsisr) : 0x00000000 Data Address (dar) : 0x5901546C 680x0 emulated registers: DATA: 00000080 000000AA 00000000 00000000 00000000 00000000 00000000 00000000 ADDR: 00000000 56162DC0 00000000 00000000 00000000 00000000 00000000 59F83380 FPU0: 0 0 0 0 FPU4: 0 0 0 0 Symbol info: Instruction pointer 0x01414890 belongs to module "kernel" (HUNK/Kickstart) Stack trace: native kernel module kernel+0x00014890 native kernel module newlib.library.kmod+0x00006210 netsurf-cairo:download_context_destroy()+0x48 (section 10 @ 0x753a0) netsurf-cairo:download_callback()+0xDC (section 10 @ 0x751b0) netsurf-cairo:llcache_object_notify_users()+0x21C (section 10 @ 0x569bc) netsurf-cairo:llcache_poll()+0x30 (section 10 @ 0x5474c) netsurf-cairo:hlcache_poll()+0x18 (section 10 @ 0x531d0) netsurf-cairo:netsurf_main_loop()+0x30 (section 10 @ 0x7fa08) netsurf-cairo:main()+0x14C (section 10 @ 0x12258) native kernel module newlib.library.kmod+0x00001f4c native kernel module newlib.library.kmod+0x00002b98 native kernel module newlib.library.kmod+0x00002d5c netsurf-cairo:_start()+0x170 (section 10 @ 0x170) native kernel module dos.library.kmod+0x0001b524 native kernel module kernel+0x00036290 native kernel module kernel+0x00036310 PPC disassembly: 01414888: 7c842378 mr r4,r4 0141488c: 44000002 sc *01414890: 4e800020 blr 01414894: 7c0802a6 mflr r0 01414898: 9421fff0 stwu r1,-16(r1)