Possible integer overflow when calculating hysteresis in desktop/netsurf.c
Dear Netsurf developers,
I would like to point out a possible integer overflow bug on systems where size_t is 32-bit. In netsurf/desktop/netsurf.c:170 -- multiplying ‘disc_cache_size’ (being 1 GB) with 20 gives 0, thus resulting in ‘hysteresis’ also becoming 0. We discovered this on Plan 9 (where size_t and int is 32-bit on both 32-bit and 64-bit systems) but my tests indicate the same result (hysteresis == 0) on 32-bit Linux/GTK. What do you think?
2 years, 4 months