Re: [NetSurf 0002266]: URLs about:welcome, about:credits and about:licence don't load localized version when the corresponding files are available
by Sprow
On 21 Jan, NetSurf Bug Tracker <help(a)netsurf-browser.org> wrote:
> The following issue has been RESOLVED.
> ======================================================================
> http://bugs.netsurf-browser.org/mantis/view.php?id=2266
> ----------------------------------------------------------------------
> (0001714) John-Mark Bell (administrator) - 2018-01-21 14:29
> http://bugs.netsurf-browser.org/mantis/view.php?id=2266#c1714
> ----------------------------------------------------------------------
> Fixed in 4302. sprintf approach is fine, but I disliked the assumption that
> ro_gui_default_language() returned a string that was 2 characters long, so
> the preceding length calculation has been updated to take account of the
> actual length of the language identifier.
I'd, perhaps wrongly, assumed that ro_gui_default_language() always returned
an ISO3166-1 country code, and hence the 2 character length was OK to
hardcode.
Regardless your mods look fine to me - thanks for integrating this,
Sprow.
PS: Can't seem to add comments to tickets once they're resolved.
5 years, 2 months
- 1
- 0
- ← Newer
- 1
- Older →