Bug 2506: can't move hotlist, history, cookies windows off screen
by Dave Higton
These windows are based on the "tree" template, which does not have the
wimp_WINDOW_NO_BOUNDS flag bit set (and there is no code to set it after
creating the window). The attached patches OR the flag bit into each of
the four template definitions that we have (de, en, fr, nl).
The bug cropped up when the tree view code was replaced.
It's my belief that this flag bit /should/ be in the templates - it's
part of the fundamental window behaviour definitions, which is what
RISC OS has templates for. Code should only be altering flag bits if
they need to be altered back and forth dynamically, e.g. to grey icons
out. I cannot see any reason why the ability to drag windows off
screen would ever need to be altered dynamically. Please speak up
if you believe differently!
OTOH if the team agrees with me, then perhaps there should be another
stage of moving this flag bit into all the window definitions. Again,
please speak up!
When applying these patches, please bear in mind that some of the
files contain top bit set characters for the non-English languages,
which may upset your text editor. The files in question are all
textual.
Dave
6 years, 10 months
- 1
- 0
- ← Newer
- 1
- Older →