Issue 2339 (case sensitivity has no effect)
by Dave Higton
I've come up with a solution that I think may be good enough. I'd
welcome a review and any suggestions for better ways.
The result of this change is that toggling case sensitivity has an
immediate effect, although it also resets the search to the start
of the list of targets. Since the list may well have changed, I
guess that's an OK consequence.
I also have some questions:
1) Are the first two additions necessary or desirable?
2) Do other platforms have the same problem?
Dave
diff --git a/riscos/search.c b/riscos/search.c
index 60b3716..f914b5c 100644
--- a/riscos/search.c
+++ b/riscos/search.c
@@ -173,6 +173,12 @@ bool ro_gui_search_click(wimp_pointer *pointer)
case ICON_SEARCH_CASE_SENSITIVE:
flags = SEARCH_FLAG_FORWARDS |
ro_gui_search_update_flags();
+ ro_gui_search_set_forward_state(true,
+ search_data.search_window);
+ ro_gui_search_set_back_state(true,
+ search_data.search_window);
+ browser_window_search_clear(
+ search_data.search_window);
browser_window_search(search_data.search_window, NULL,
flags,
ro_gui_get_icon_string(dialog_search,
____________________________________________________________
Can't remember your password? Do you need a strong and secure password?
Use Password manager! It stores your passwords & protects your account.
Check it out at http://mysecurelogon.com/password-manager
7 years, 2 months
Issue 2339 (case sensitivity has no effect)
by Dave Higton
I've just done some experiments which, I think, get us closer to
understanding the problem.
I've uploaded a new version of the test file "index.html" which now
puts the words onto separate lines, so that "Show all" shows better
the matching targets.
Search for "Ca", set "Show all" and toggle case sensitivity. The
highlights don't change. Make a change to the search target string,
though, and the matches are immediately updated.
I changed the code in ro_gui_search_click() so as to search for " "
immediately before searching for the real target. Now the highlights
are updated immediately the case sensitivity is toggled.
This suggests to me that the search term is being cached, and the
search command does nothing if the search term does not change. But
it /must/ search again if the flags are changed.
I can't see where the ultimate function is because it's called
"search(...)" which is too generic a name to search for.
I've updated Mantis with my findings.
Hth,
Dave
____________________________________________________________
FREE 3D EARTH SCREENSAVER - Watch the Earth right on your desktop!
Check it out at http://www.inbox.com/earth
7 years, 3 months
Re: netsurf: branch master updated. release/3.3-531-gd7907bf
by Daniel Silverstone
On Wed, Nov 25, 2015 at 00:12:06 +0000, NetSurf Browser Project wrote:
> commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=4ad94124a693528f2ac...
> commit 4ad94124a693528f2ac47a9b4b2e12880586aedf
> Author: Chris Young <chris(a)unsatisfactorysoftware.co.uk>
> Commit: Chris Young <chris(a)unsatisfactorysoftware.co.uk>
>
> Skip invalid commandline args instead of aborting
>
> diff --git a/utils/nsoption.c b/utils/nsoption.c
> index ccdd23a..c83f779 100644
> --- a/utils/nsoption.c
> +++ b/utils/nsoption.c
> @@ -734,8 +734,10 @@ nsoption_commandline(int *pargc, char **argv, struct nsoption_s *opts)
>
> /* check we have an option */
> /* option must start -- and be as long as the shortest option*/
> - if ((arglen < (2+5) ) || (arg[0] != '-') || (arg[1] != '-'))
> - break;
> + if ((arglen < (2+5) ) || (arg[0] != '-') || (arg[1] != '-')) {
> + idx++;
> + continue;
> + }
>
> arg += 2; /* skip -- */
This seems odd Chris.
Instead of stopping consumption of arguments on the first non-configuration
argument, it instead ends up swallowing the entire commandline rendering the
rest of commandline processing worthless.
Could you either fix this so that you get your desired behaviour while not
breaking processing for the rest of us; or else revert the change?
Previously the expectation was:
nsexecutable [nsoption arguments] [frontend specific arguments] [url to launch with]
Now we have:
nsexecutable [nsoption arguments] [anything else is ignored blithely]
Thanks,
Daniel.
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
7 years, 3 months
Suggestion for priority of work
by Dave Higton
One of the things that NetSurf users most miss, it seems to me, is to
be able to configure small appliances via their web pages that rely
heavily on Javascript. Examples are wifi clients and other network-
related stuff. We keep seeing threads on newsgroups and mailing
lists that always have to say "but you'll need Linux or Windows to
set it up".
How much work would be involved in supporting them, and is there other
work that has a higher priority?
As you see, it's a naive question.
Dave
____________________________________________________________
Can't remember your password? Do you need a strong and secure password?
Use Password manager! It stores your passwords & protects your account.
Check it out at http://mysecurelogon.com/password-manager
7 years, 3 months
Bug 2388
by Dave Higton
My fix for issue 2388 was rejected, apparently without looking at
what I submitted. I /did/ submit the text source files for the
templates.
Please have another look!
Dave
____________________________________________________________
FREE ONLINE PHOTOSHARING - Share your photos online with your friends and family!
Visit http://www.inbox.com/photosharing to find out more!
7 years, 3 months
back to the future
by John Rickman Iyonix
The times in the bug tracker seem to be 10 minutes or so in the
future.
2015-11-18 10:05 David Pitt Note Added: 0001103
2015-11-18 10:18 Michael Drake Note Added: 0001104
2015-11-18 10:19 Michael Drake Fixed in CI build # => 3062
2015-11-18 10:19 Michael Drake Status confirmed => resolved
2015-11-18 10:19 Michael Drake Resolution open => fixed
2015-11-18 10:19 Michael Drake Fixed in Version => 3.4
2015-11-18 10:19
As I write the time is 10:18
John
--
John Rickman - http://rickman.orpheusweb.co.uk/lynx
7 years, 4 months
Bug tracker blocked
by Dave Lawton
Hi all,
I would like to try and contribute but ...
The site
http://bugs.netsurf-browser.org/mantis/
is blocked at my workplace by Websense as being
in a Static category: Proxy Avoidance.
Is there anything that can be done to alleviate
this please ?
I do believe that Websense is a third-party product
which does regular updates.
TIA
--
Regards from Dave Lawton
HTML emails are just a security risk, and nobody needs that.
7 years, 4 months
Re: Bug 2289: UI inconsistency - don't use no double negatives!
by Sprow
On 14 Nov, NetSurf Bug Tracker <help(a)netsurf-browser.org> wrote:
> ======================================================================
> http://bugs.netsurf-browser.org/mantis/view.php?id=2289
> ======================================================================
> Reported By: Simon Smith Resolution: won't
> fix
>
> Description: The RISC OS content config window has checkboxes for 'Hide
> advertisements', 'Disable pop-up windows' and 'Disable Javascript'. So you
> have to turn a checkbox /on/ to turn something /off/. That's a double
> negative, which is confusing UI design. Please reverse the sense of the
> checkboxes and adjust their names accordingly.
As I can't append comments to tickets marked as closed, I'll spill over into
this mailing list instead:
> ----------------------------------------------------------------------
> (0001088) Dave Higton (developer) - 2015-11-14 21:06
> http://bugs.netsurf-browser.org/mantis/view.php?id=2289#c1088
> ----------------------------------------------------------------------
> We discussed this issue at the recent Developer Weekend. There is no
> perfect answer.
>
> The existing scheme has check boxes that are expected NOT to be ticked for
> the normal case: advertisements allowed, pop-up windows allowed, Javascript
> enabled.
>
> We chose to continue with the check boxes operation in this sense.
Vincent's initial comment (note #0000768) stated that this issue only
affected the RISC OS front end, and indeed when I checked the GTK version the
options are phrased the other way round.
The issue of poor wording of dialogues, in particular double negatives, is
called out on page 66 of the Style Guide: "use the same sense for all options
within a dialogue".
Note, my patch didn't change any of the defaults, merely brought them into
line with the other front ends.
If you're choosing to not apply this to the RISC OS front end, then surely
the ticket should be reopened and applied to the non RISC OS front ends so
that they are phrased with double negatives; otherwise the logic for closing
this one is flawed,
Sprow.
7 years, 4 months
