Memory leak in inputstream.c
by Ralf Junker
If an unsupported encoding is passed to hubbub_parser_create(), libparserutils/src/input/inputstream.c will cause a memory leak because is does not free allocated objects before returning.
Here is a proposed fix, I hope you find the context in parserutils_inputstream_create():
if (enc != NULL) {
parserutils_filter_optparams params;
s->mibenum =
parserutils_charset_mibenum_from_name(enc, strlen(enc));
if (s->mibenum == 0) {
parserutils__filter_destroy(s->input); /* Added. */
parserutils_buffer_destroy(s->public.utf8); /* Added. */
parserutils_buffer_destroy(s->raw); /* Added. */
free(s); /* Added. */
return PARSERUTILS_BADENCODING;
}
params.encoding.name = enc;
Ralf
9 years, 4 months
next release of libcss?
by David Tardon
Hello,
I have seen some API breaking changes in libcss master since the last
release. Is there any plan / roadmap / estimate when a new release is
going to happen?
D.
9 years, 4 months
libcss and libhubbub in Fedora
by David Tardon
Hello,
I have packaged libcss, libhubbub and their dependencies
(netsurf-buildsystem, libparserutils and libwapcaplet) for Fedora. They
are available in Rawhide, but I have no plans (so far) to put them into
any released version. The packages needed some tweaks to build as we
(Fedora) need them and there were at least one build warning/error, so I
am going to send patches during the next few days. I am also going to
try the build on other platforms I can get access to: ppc, ppc64, s390
and s390x; these may result in additional patches :-)
My motivation is that I have started to use them in one of my projects
(https://sourceforge.net/projects/libebook/), which is packaged in
Fedora, so I will eventually need them too. There is really not much
choice when one wants a small and simple C/C++ library for parsing HTML
and CSS (I am not interested in JavaScript and similar trash)...
Btw, congratulations for the libhubbub tree builder API documentation:
it was a piece of cake to implement the callbacks. I wish libcss
selector API was documentated just as well: I had to look into the code
how several of the callbacks are used to implement them (hopefully)
correctly.
Note that libe-book itself is used in LibreOffice (starting with the
upcoming 4.2), which means that in time the libs will have to be
packaged for other linux distributions too. They will also be bundled
and built inside LibreOffice on Windows and OS X.
D.
9 years, 4 months
Fwd: lib64 in pkgconfig file.
by Michael Drake
This was sent to me, but belongs here.
------ Forwarded message ------
From: Christopher Meng <cickumqt(a)gmail.com>
Date: 09 Jan 2014 1205
Subject: lib64 in pkgconfig file.
Hi,
Several lib of netsurf doesn't use cmake or autofool( ;) ) to
configure, so on 64 arch systems, Fedora uses /lib64(now /usr/lib64 as
/usr/lib in i686).
pkgconfig.in contains sample:
prefix=PREFIX
exec_prefix=${prefix}
libdir=${exec_prefix}/lib
includedir=${prefix}/include
Name: libhubbub
Description: HTML5 parsing library
Version: VERSION
Requires: libparserutils
Libs: -L${libdir} -lhubbub
Cflags: -I${includedir}
So we need to patch them everytime in building..
Do we have any plan of moving to cmake or other building systems or
even autofool? ;)
Also, -Werror option shouldn't be enabled in released tarballs since
sometimes we can't build them anymore.
Thanks.
--
Yours sincerely,
Christopher Meng
Noob here.
http://cicku.me
------ End forwarded message ------
--
Michael Drake http://www.smoothartist.com/
9 years, 4 months
Form select gadgets
by Chris Young
Is there any way of adding a down arrow to the form select gadgets,
maybe using CSS? The select gadgets here look a bit odd if I change
the frame to be raised (because they look like normal buttons), but I
think raised with a down arrow (or rather, a V with a line under it)
at one end, or even Windows-stye (embossed but with a raised down
arrow button at one end) would (a) fit in with the OS4 style better
and (b) be more intuitive for the user, as it's not obvious it's a
popup until the mouse is hovering over it. Actually I thought RISC OS
normally had a popup button next to this sort of thing, so something
similar might make sense there too?
Can it be done in the default style CSS, or does it need to be coded
into the select forms in the main code?
Chris
9 years, 4 months
Re: netsurf: branch master updated. release/3.0-909-gb1e6c63
by Chris Young
On Sun, 05 Jan 2014 15:51:33 +0000, Commit Mailer wibbled on for an age:
> Rewrite form_successful_controls() to use the DOM.
>
> This stops image inputs from working temporarily, but makes
> inputs inside display:none work correctly. As such, this is
> a net-win.
This seems to have introduced a curious bug, where all checkboxes are
submitted as ticked, no matter what their actual state is.
Chris
9 years, 4 months
AGM minutes
by Michael Drake
Here are the minutes of the 2013 NetSurf AGM.
Thanks to Daniel Silverstone for recording them.
---------------------------------------------------------------------------
NetSurf AGM
===========
Attendees
---------
* Daniel Silverstone
* Vincent Sanders
* Michael Drake
* Rob Kendrick
* Chris Young
* François Revol
Welcome
-------
Michael welcomed everyone to the 2013 NetSurf AGM.
Secretary's Report
------------------
Last year's society committee consisted of:
Michael Drake, Chair
John-Mark Bell, Treasurer
Daniel Silverstone, Secretary
Last year's non-committee membership consisted of:
Rob Kendrick
Chris Young
Vincent Sanders
François Revol
Steve Fryatt
Nobody has left and noone has joined, thus the society stands at 8 members
and as such remains functional.
Treasurer's Report
------------------
Unfortunately we do not have an up-to-date treasurer's report at this time.
John-Mark is unable to attend.
However, we have an August 4th report:
<http://vlists.pepperfish.net/pipermail/netsurf-dev-netsurf-browser.org/20...>
Since August 4th, approximately 300 UKP has been spent on CI server
hosting for the coming year.
Chairman's Report
-----------------
The chairman's report can be found at:
<http://vlists.pepperfish.net/pipermail/netsurf-dev-netsurf-browser.org/20...>
Since this report, treeviews have been added. The only blocker against 3.1
is the reworking of forms.
Committee Election
------------------
I have received nominations and seconds for the incumbent society committee
members. No incumbent has declined the nominations. Thus the question to
vote on is "Should the incumbent committee serve for another year?".
Everyone present voted in favour of the incumbents.
Since no votes against were registered before the meeting, the incumbents
are hereby elected to remain as the service committee for the coming year.
Project steering
----------------
Michael reiterated that the short-term project goal is to get 3.1 done
since the release of 3.0 was somewhat rushed. Longer term, our goal
remains dynamic layout and better JS integration, along with correcting
our CSS selection performance which is currently very poor.
Vincent pointed out that JavaScript integration needs the binding
generator's support for inherited elements to be improved and that after
then, it is mostly just writing the DOM bindings. Vincent even believes
that the bindings may be able to be automatically built, but he lacks time
to achieve this for now.
Daniel suggested a hack weekend. Michael agreed and Vincent offered to
host. Rob pointed out that Codethink could possibly host too if people
fancied Manchester instead of Cambridge. Michael suggested we wait and
consult with John-Mark about dates etc. He also called for a possible
attendance list. Michael, Vincent, Daniel and Rob all indicated an
ability to attend.
AI: Vincent to liase with John-Mark and then make a plan for a hack
weekend.
Chris raised that printing gets mentioned to him. This comes back to
content cloning which is a known issue at this time. François asked how
much of printing is platform-specific. Initially printing would be
generating a PDF which makes it mostly core. Rob wondered if it might be
worth writing a PostScript render backend. Michael reminded the meeting
that we'd need stylesheet selection, @media handling etc. and for the
layout engine to properly support pagination.
Daniel proposed that we shelve printing for now, and reconsider it when
determining requirements for the new layout engine. Everyone agreed.
Michael suggested we might be able to achieve some kind of poor quality
print short-term if we wanted.
A.O.B
-----
### Bug Trackers
Michael raised that the SourceForge bug tracker no longer functions in
NetSurf. Rob suggested that we could fire up a BTS on one of the machines
we use for CI. Daniel asked if Rob had any suggestions for which BTS to
run. Rob stated a dislike for them all.
Vincent pointed out that there's plenty of headroom on the CI master
machine now. Mantis can be run in a VM with one CPU and 512MB of RAM.
Chris indicated that he ran a Mantis for a while and that it worked with
NetSurf when he did. Michael and Vincent both raised importing the old BTS
data.
AI: Rob Kendrick to research bug trackers and suggest one which can be run
reasonably easily and will work with NetSurf. Expectation is Mantis
but there are other options.
### Continuous Integration
Vincent reported:
The CI system now consists of four systems. Two are MacOS-X systems and
two are x86 VMs hosted by Mythic Beasts. The Mythic beasts systems have 2
gigs of RAM each and we run Jenkins and the downloads sites on one and use
the other as a build slave.
Vincent raises the question: What about continued support for the
platforms not under CI, and also MacOS-X PPC. Michael pointed out that
this involves the BeOS port since that cannot be CI'd at this time, and
that MacOS-X PPC cannot run Java 1.6 which prevents us from upgrading
Jenkins.
Michael asked if it is impossible to cross-build the MacOS-X port. Vincent
said yes, hence the native builders.
François pointed out that for BeOS/Haiku to be CI'd, he'd need to sort
out the cross-toolchain. Since the toolchain is not meant for building
outside of Haiku's build process it will be a pain. Rob pointed out that
we'd want the cross-environment to be prepared in the same way as all the
other systems and François agreed.
Vincent pointed out that if we can run Java 1.6 on Haiku then we could
host a "real" build slave on it. François pointed out that non-gui stuff
might be possible and Vincent agreed that the Jenkins slave is headless.
In theory therefore it might be possible.
AI: François to research the build options for Haiku and BeOS and come
back to the group with a proposal for getting it into CI or else
dropped.
Michael advocated dropping MacOS-X PPC after 3.1. Vincent explained that
the PPC port of MacOS-X doubles the build time on the CI.
Michael asked Chris if the Amiga CI builds see much action. Chris said
that he knows of a few people who download them. Vincent asked if there
was any way to improve matters and Chris asked for a 'With JS' build.
Vincent asked Chris to update the Amiga cross-toolchain to the appropriate
Spidermonkey release and then he will enable them.
AI: Chris to sort out Spidermonkey for the Amiga cross-toolchain
Closing
-------
Michael thanked everyone for attending. Daniel indicated that these
minutes will be posted to the mailing list soon.
--
Michael Drake (tlsa) http://www.netsurf-browser.org/
9 years, 4 months
