(Documentation?) bug in libCSS css_computed_style_compose?
by James Montgomerie
Hello,
I'm working on libCSS just now, implementing support for some of the 'page' properties (page-break-before, page-break-after etc). I've noticed what I think is a bug in css_computed_style_compose, and I wanted to run it past the experts before trying to fix it, in case I've got the wrong end of the stick.
The symptoms are that properties that should by default /not/ inherit are inheriting.
The cause, I think, is in css_computed_style_compose. It happens when 'child' and 'result' point to the same object, and parent has 'page' group properties set (I think this will apply equally to the current 'uncommon' group), but the child does not. In the loop, when we get to the first set property in a group, it is composed (because the group in parent is not NULL), which causes the group to be allocated in the result object (the setters allocate the group if it doesn't already exist), and memset to 0. This meant that, because 'child' and 'result' are the same, all the other properties in 'child' are now set to 0 (by the memset when the group is set up). 0 is 'inherit'. Properties that /should/ have a non-inherit initial value are now set to inherit erroneously.
The solution is either to call initial_... for all the properties in the group when it's set up (in the "ENSURE_PAGE" macro, or equivalent), or maybe to change the docs to state that child and result may NOT be the same object.
Does this sound like a plausible diagnosis?
Thanks,
Jamie.
12 years, 6 months
PLOT_TYPE fgcol create a word variable in 16 bit which seem wrong
by Bernd Roesch
Hi,
As far i understand the text in netsurf is always in ABGR Format.
but in 16 bit libnsfb fgcol is define as a word variable(i see in debugger).white text is show as
yellow on 16 bit SDL screen.
here fgcol is set.
fgcol = c & 0xFFFFFF;
this is code in src/plot/common.c
static bool
glyph8(nsfb_t *nsfb,
nsfb_bbox_t *loc,
const uint8_t *pixel,
int pitch,
nsfb_colour_t c)
{
PLOT_TYPE *pvideo;
PLOT_TYPE fgcol;
nsfb_colour_t abpixel; /* alphablended pixel */
int xloop, yloop;
int xoff, yoff; /* x and y offset into image */
int x = loc->x0;
int y = loc->y0;
int width = loc->x1 - loc->x0;
int height = loc->y1 - loc->y0;
if (!nsfb_plot_clip_ctx(nsfb, loc))
return true;
if (height > (loc->y1 - loc->y0))
height = (loc->y1 - loc->y0);
if (width > (loc->x1 - loc->x0))
width = (loc->x1 - loc->x0);
xoff = loc->x0 - x;
yoff = loc->y0 - y;
pvideo = get_xy_loc(nsfb, loc->x0, loc->y0);
fgcol = c & 0xFFFFFF;
Bye
12 years, 6 months
Weird text alignment problem
by Chris Young
Hi all
My port of NetSurf seems to be afflicted with a strange text alignment
problem. As far as I can tell, it is related to superscripted
text and whether it is a link or not.
On http://www.amigans.net the page numbers for threads are shown thus:
Thread title [1] [2] [3]
Where the links ("Thread title", "1", "2" etc) are shown in what I
believe to be the correct position, and the brackets are shown
superscripted. Please see attached screenshot :)
I've checked another browser and the GTK version of NetSurf, and both
show all the text at the same vertical offset - so I think it's
something to do with my text positioning code.
It's very rare to see this - normal links in text are fine - so maybe
that is supposed to be superscripted? Although if that is the case,
why aren't the links?
Another example is "citation needed" on Wikipedia, which does exactly
the same on OS4 NetSurf, but shows completely superscripted on another
browser. (I haven't checked GTK NetSurf yet - there's a "citation
needed" at the end of "Grid Squares" on
http://en.wikipedia.org/wiki/Milton_Keynes for reference - and I've
attached a screenshot of this too)
Anybody have any idea what might be causing this or how I might go
about fixing it?
Chris
12 years, 6 months
Netsurf committee
by Vincent Sanders
I would like to second the nomination of Michael to remain as Chair
and John-Mark to remain as Treasurer.
I would also like to nominate Daniel to remain as Secretary.
--
Regards Vincent
http://www.kyllikki.org/
12 years, 6 months
NetSurf Society Financial Report
by John-Mark Bell
NetSurf Society Financial Report, March 2011
============================================
Overview
--------
This is a summary of the society's financial status as of 2011-03-27.
Rob Kendrick has kindly corrected the treasurer's mistake from last year
and repaid the excess 20 pence he was reimbursed with. This is reflected
in the income section of the detail, below.
The remaining source of income over the last 12 months has been the
takings from sales of NetSurf 2.5 at the Wakefield 2010 show.
All outgoings have been in the form of reimbursements for
project-related activities or show stand bookings.
As resolved at the 2010 AGM, the society will now pay up to 15 pence per
mile for mileage.
Detail
------
Balance carried forward: 1607.07
Income:
2010 Wakefield Show sales 247.00
Rob Kendrick 0.20
Expenditure:
CD Jewel cases (1.00)
Michael Drake -- train tickets:
EDB->WKF->EDB Wakefield 2010 (50.00)
EDB->MAN->EDB Dec 2010 hack (56.50)
EDB->MAN->EDB Mar 2011 hack (64.60)
John-Mark Bell[1]:
510 miles RDG->WKF->MAN->SOU Wakefield 2010 (51.00)
Lunch & blank CDs Wakefield 2010 (33.66)
390 miles RDG->MAN->RDG Dec 2010 hack (39.00)
390 miles RDG->MAN->RDG Mar 2011 hack (39.00)
Lunch Mar 2011 hack (23.50)
Wakefield 2011 stand (40.00)
Remaining Funds: 1456.01
Notes
-----
1. I am currently claiming 10pence/mile as this better reflects
the actual cost to me of the distance travelled.
12 years, 6 months
Netsurf 2.7 release
by Vincent Sanders
As per our release schedule on the wiki [1] I shall be creating the
release branch today.
Please ensure any bugfixes etc. are commited as soon as posible,
however no new features should be going in at this time.
Our target release frontends are:
* RISC OS
* GTK
* Amiga OS 4.0
* Cocoa
Tech preview frontends are:
* Windows
Non release frontends:
* framebuffer
* beos
* atari
* monkey
If this is incorrect the relevent maintainer should let me know as
soon as they can!
[1] http://wiki.netsurf-browser.org/NetSurf_2.7
--
Regards Vincent
http://www.kyllikki.org/
12 years, 6 months
NetSurf Society membership and AGM, 2011
by Daniel Silverstone
Greetings.
This mail is to establish the society membership (and thus voting rights) and
to indicate the AGM for 2011 along with asking for any business to be brought
up at the meeting.
Last year's society committee consisted of:
Michael Drake, Chair
John-Mark Bell, Treasurer
Daniel Silverstone, Secretary
Last year's non-committee membership consisted of:
Rob Kendrick
James Bursa
Chris Young
Vincent Sanders
Bo Yang
François Revol
John Tytgat
Steve Fryatt
By constitutional point 2.1, anyone who has committed code in the past 12
months (or had code committed on their behalf) is eligible for membership of
the society. By point 7.2, anyone ceasing to qualify to be a member of the
society is automaticall removed from the list.
Since we're aiming to get the society membership calculated based on the date
of the AGM, I will be considering commits to the repository from r10474 which
was late on the afternoon of the AGM 2010.
Bo Yang is therefore removed from society membership, and the following people
are eligible to join the membership:
Sven Weidauer (swdr)
Ole Loots (mono)
If Sven or Ole want to attend the AGM and be able to vote/raise issues then
they should contact me directly (not on list) to indicate such as per
constitutional point 5. A simple "I wish to be part of the NetSurf Society"
type statement will be sufficient.
The AGM this year is to be held on April 16th at 14:00 UK time (which will be
13:00 UTC). As with previous AGMs it will be held on the NetSurf IRC channel
and as such will be open for all to attend. Please do not actively say
anything in-channel unless you are part of the membership of the society
however. (We may moderate the channel for the duration if necessary).
The agenda will be finalised and sent out on or before the 9th of April. If
you have any business to add to the normal agenda then please contact me and
let me know.
We also require nominations and seconds for committee positions. I personally
nominate Michael to remain as Chair and John-Mark to remain as Treasurer.
Nominations and seconds should be sent to the list in response to this message
such that we can all see what is going on. Nominations will close when the
finalised agenda is sent out.
Regards,
Daniel Silverstone
Secretary, NetSurf Project Society
--
Daniel Silverstone http://www.netsurf-browser.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
12 years, 6 months
Re: Peek Browser
by Rob Kendrick
On Tue, Mar 22, 2011 at 10:46:06AM -0400, dan morel wrote:
> I think you guys have talked to a few folks before at Peek. We have a new
> device launching in India and we are looking to put a browser on it. It's
> got a bit more horsepower than the last device, but its a c-only environment
> and we still have to be pretty thoughtful about CPU, memory, etc - so we'd
> love to figure out how to put netsurf on it.
>
> How far along are you guys on v3 with js support? Can we help contribute at
> all?
Hi Dan,
We are quite some distance off. You can see our development plan here:
http://wiki.netsurf-browser.org/Development_Plan
Please note that we are a small (fewer than 10 regular contributors)
project who work purely on personal and donated time. We always welcome
addititonal contribution from individuals and corporate organisations.
If you'd like to discuss such, you can contact us on IRC (#netsurf on
irc.freenode.net) or on our development mailing list. Details of both
can be found here:
http://www.netsurf-browser.org/contact/
I hope this helps,
B.
12 years, 6 months
svn-testament.pl
by m0n0
Hello,
the current version of Netsurf doesn't link, because of:
Can't locate Digest/MD5.pm in @INC (@INC contains:
/usr/lib/perl5/5.6.0/m68k-atari-mint /usr/lib/perl5/5.6.0
/usr/lib/perl5/site_perl/5.6.0/m68k-atari-mint
/usr/lib/perl5/site_perl/5.6.0 /usr/lib/perl5/site_perl .) at
utils/svn-testament.pl line 114.
BEGIN failed--compilation aborted at utils/svn-testament.pl line 114.
I prefer not to install such an module (MD5.pm) on my freemint system,
is that okay?
Greets,
m
12 years, 6 months
