Re: r7040 struggleyb - in /branches/struggleyb/domts-transform-perl: DOMTSHandler.pm testutils/domts.h testutils/domtsasserts.c testutils/domtsasserts.h testutils/domtscondition.h testutils/misc.h testutils/test.h testutils/utils.c testutils/utils.h
by John-Mark Bell
On Fri, 2009-04-03 at 14:21 +0000, netsurf(a)semichrome.net wrote:
> Log:
> Add support for <or>, <and>, <xor> and most of the condition statement of DOMTS.
You probably want to read docs/TestSuite -- James enumerated the
requirements for each of the assertions there. I've not looked at your
perl to see if you handle expressions there or expect domtsasserts.c to.
> Added: branches/struggleyb/domts-transform-perl/testutils/domtsasserts.c
> URL: http://source.netsurf-browser.org/branches/struggleyb/domts-transform-per...
> ==============================================================================
> --- branches/struggleyb/domts-transform-perl/testutils/domtsasserts.c (added)
> +++ branches/struggleyb/domts-transform-perl/testutils/domtsasserts.c Fri Apr 3 09:21:04 2009
> +/* Is the void * suitable for all types? */
No reason why not.
> +bool assert_null(void *arg)
> +{
> + return arg == NULL:
> +}
> +
> +/* Whether compare two pointers are suitable? */
> +bool assert_same(void *excepted, void *actual)
> +{
> + return excepted == actual;
> +}
This may be more complex than the above. Collections expect you to
compare their sizes/members, for example. I think that needs to defer to
assert_equals.
> +bool assert_equals_dom_string(dom_string *excepted,const char *actual, bool ignoreCase)
> +{
> + dom_string *str;
> + dom_exception exp;
> +
> + exp = dom_string_create(myrealloc, NULL, actual, strlen(actual), &str);
> + if (exp != DOM_NO_ERR) {
> + fprintf(stderr, "Error in alloc dom_string in assert_equals_dom_string\n");
> + return exp;
> + }
> +
> + if (ignoreCase)
> + return dom_string_icmp(excepted, str);
> + else
> + return dom_string_cmp(excepted, str);
> +}
This leaks str.
> +bool assert_not_equals(dom_string *excepted, dom_string *actual, bool ignoreCase)
> +{
> + return !assertEquals(excepted, acutal, ignoreCase);
> +}
I'd prefer to see "== false" here.
> +bool assert_instanceof(dom_node *node, const char *type)
> +{
> +}
You'll want to examine the dom_node_type, here.
> +bool assert_uri_equals(char *scheme, char *path, char *host,
> + char *file, char *query, char *fragment,
> + bool isAbsolute, dom_string *actual)
> +{
> +}
Again, see James' notes.
J.
12 years, 5 months
Re: Patch ID for FTP
by shirish a
Hi,
Revised patch implementing the strstr function rather than comparing
character by character.
Thank you,
Your sincerely,
Shirish Reddy.
On Fri, Apr 3, 2009 at 2:19 PM, Mark <markieb.lists.20090330(a)gmail.com>wrote:
> ps look at the function strstr
> http://www.cplusplus.com/reference/clibrary/cstring/strstr.html
>
> Best
>
> Mark
> http://www.halloit.com
>
> Key ID 046B65CF
>
>
>
> shirish a wrote:
>
> Hi,
>
> sir, I have not known that this functionality already exists, but i have
> submitted patch as a part of the gsoc proposal.
>
> Thanking you,
>
> Yours sincerely,
> Shirish reddy
>
>
12 years, 5 months
Re: Patch ID for FTP
by Rob Kendrick
On Fri, 3 Apr 2009 09:04:24 +0530
shirish a <shirishreddy89(a)gmail.com> wrote:
> As we know that to download files from ftp we need to use some
> specific ftp clients or else it becomes a task to download each and
> evey single file listed on the ftp server, having identified whether
> the host is ftp there is possibility in future to facilitate the
> downloads in a more convenient fashion, May design a some plug ins to
> handle the downloads (to download entire folder at a time rather than
> file by file ).Hope the idea is appealing.
Hi,
Please reply to the list, and avoid top-quoting.
NetSurf already has infrastructure for just this (RISC OS uses it).
Also, your patch adds a function that never gets called from anywhere,
so it is of limited value other than making the executable larger,
currently.
> On Fri, Apr 3, 2009 at 4:30 AM, Rob Kendrick
> <rjek(a)netsurf-browser.org>wrote:
>
> > On Thu, 2 Apr 2009 23:10:16 +0500
> > shirish a <shirishreddy89(a)gmail.com> wrote:
> >
> > > Hi every one,
> > >
> > > I have just written a small code to identify whether the url is
> > > ftp or not Attached is the .diff file for the patch.
> >
> > Hi,
> >
> > Could you tell me what this patch is for? Also, it'll have more
> > chance of being applied if it is written to our source code
> > standards demonstrated in the rest of the source code.
B.
12 years, 5 months
Please comment on my proposal
by rohyt
Hello every one, I have submitted the proposal
Title: Rich Keyboard Navigation
Name: rohyt.itbhu(a)gmail.com
Link ID: rohyt
Please comment on my proposal
Rohit Jaiswal
BTech III year
IT-BHU, Varanasi, India
12 years, 5 months
Proposal by diaswrd (Improved GTK front end )
by William Dias
GSoC 2009 - Netsurf Project
William Regis Drawanz Dias
e-mail: wdias.ifm(a)ufpel.edu.br
diaswrd at #freenode
::: Google Summer of Code 2009 Proposal :::
About Me
===================
I am a fifth semester student of Computer Science at the Federal University
of Pelotas, Brazil, with especially knowledge
in C/C++ and Python languages. Currently I am member of an Artificial
Intelligence research group at University called GAIA (in English,
Artificial Intelligence Aplications Group). I am interested in increasing my
skills and knowledge related to C programming in a practice software
project.
I have much free time and remain several hours on the computer, both at home
and at University. A full-time contribution will not be a problem for me. I
am very excited to work with cool and interesting people.
Project Description
===================
I would like to explore the Front End Improvement suggested at the Netsurf
ideas page. This include new functionalities and facilities to the browser
users.
My short list of Netsurf improvements suggestions are:
To create a text Find system containing many important functionalities like
Previous search result option, After search result option and others new
features I do like to propose. For example, to find separately words inside
the text. If the user only knows few words of the text he are looking for,
the Find system will help him and show him the closest words combinations he
typed in the field.
To create an easy handling Bookmarks to facilitate user access to your
favorites pages on the Internet. Also, the system will provide to the users
the possibility to separate their favorite pages in custom groups.
To implement a simple and to the point Source Code Viewer, using a
simplified colored visualization featuring, separating the commented code
lines and the other code lines, for example. Also I would like to implement
line numbers on the Viewer to help the user to more easily find what he
want.
To improve the right-click menu adding new essentials features to the
browser, including options such as "Open in New Tab", "Open in New Window",
"Save image as..", "Copy URL" and others, to provide a more practical
navigation to the user. As is it illustrated in the image below.
http://img27.imageshack.us/img27/6553/rightclickm.jpg
To create the most helpful user guide as I can, containing all the
properties and functionalities of the Netsurf Browser, providing to the user
an faster and easier navigation at the internet .
To add Favicons beside the address field, and if possible, also in the
Bookmarks list and in any Tab opened at the moment.
As is it illustrated in the image below.
http://img25.imageshack.us/img25/2881/faviconetsurf.jpg
Project Milestones
===================
April 20: Start to organize sources and learn more about GTK to make first
definitions in the project.
May 23: Complete the studies about GTK and Netsurf source code, and
starting to implement the front-end ideas.
June 30: At this time a good part (at least half) of the project will be
implemented and working. It is time to organize the mid-term evaluations.
July 6~13: Begin to look more about the project difficulties and forward the
project code to the end.
August 10: Improve and organize project documentations to final evaluation.
Project Tests
===================
At any progress achieved during the project execution, some tests could be
performed to investigate if the proposed functionality works fine or not.
All the code will be commented in order to facilitate the search for errors
and important code lines. In the final of any successful implementation, I
am intended to provide for friends and who are interested a beta version of
the browser, containing the new added and implemented functionalities, to be
tested and evaluated directly by users.
12 years, 5 months
Patch ID for FTP
by shirish a
Hi every one,
I have just written a small code to identify whether the url is ftp or not
Attached is the .diff file for the patch.
thankyou,
yours sincerely,
shirish reddy
12 years, 5 months
Re: [Patch] Added Local history button in GTK interface
by edi
Ok, third shot at it and hopefully the last one (sorry Daniel for
previous message, it contained makefile diff in patch).
General description:
This patch adds history button between forward and back in GTK
interface. This time for newly opened window AND tab (Ctrl-T
accelerator) focus stays on the URLbar. I've also formatted code
according to guidelines provided by Daniel and John.
To-do:
Next step would be to make this new button behave like it's older
brother in Firefox (on "clicked" event application will draw text list
of local history). And I'll check how to make local history window
transient (after duration, on focus lose?).
And I've been thinking - maybe it's a good idea to open local history
window as a new tab (like Speed Dial in Opera or it's equivalent in
Firefox) when it's invoked with accelerator or menu item.
--
Regards,
Chris Tarnowski.
-------------------------------
PGP Key-Id: C33C A45D
IRC: 3d1
12 years, 5 months
Revised-patch
by shirish a
I apologize for sending a faulty patch file to the mailing list the orignal
patches to the url.c and url.h in the utils directory are attached here,
I request the respective authorities dealing with this to re-consider the
submission of my patch .
Thanking you,
Yours sinceerely,
Shirish Reddy
12 years, 5 months
patch
by shirish a
Where should be a patch be posted please reply.
12 years, 5 months
