Gitweb links:
...log
http://git.netsurf-browser.org/libdom.git/shortlog/47e3fe106a9cd7ae722729...
...commit
http://git.netsurf-browser.org/libdom.git/commit/47e3fe106a9cd7ae72272955...
...tree
http://git.netsurf-browser.org/libdom.git/tree/47e3fe106a9cd7ae7227295519...
The branch, master has been updated
via 47e3fe106a9cd7ae72272955194a0ea9ae528820 (commit)
from d621b4cc86289f23b11f2050d5dcfbf025a3218f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/libdom.git/commitdiff/47e3fe106a9cd7ae7227...
commit 47e3fe106a9cd7ae72272955194a0ea9ae528820
Author: Michael Drake <tlsa(a)netsurf-browser.org>
Commit: Michael Drake <tlsa(a)netsurf-browser.org>
Fix comparison of signed/unsigned variables.
diff --git a/.gitignore b/.gitignore
index a12a172..9d29615 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,5 +3,4 @@ build-*
build/docs
examples/dom-structure-dump
test/level*.c
-test/INDEX
*~
diff --git a/include/dom/html/html_select_element.h
b/include/dom/html/html_select_element.h
index 6999368..42aef00 100644
--- a/include/dom/html/html_select_element.h
+++ b/include/dom/html/html_select_element.h
@@ -80,7 +80,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element
*select,
(struct dom_html_element *) (e), \
(struct dom_html_element *) (b))
dom_exception dom_html_select_element_remove(dom_html_select_element *ele,
- long index);
+ int32_t index);
dom_exception dom_html_select_element_blur(struct dom_html_select_element *ele);
dom_exception dom_html_select_element_focus(struct dom_html_select_element *ele);
diff --git a/src/html/html_select_element.c b/src/html/html_select_element.c
index 4efffb9..12ea6ba 100644
--- a/src/html/html_select_element.c
+++ b/src/html/html_select_element.c
@@ -536,7 +536,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element
*select,
}
dom_exception dom_html_select_element_remove(dom_html_select_element *ele,
- long index)
+ int32_t index)
{
dom_exception err;
uint32_t len;
@@ -547,7 +547,7 @@ dom_exception dom_html_select_element_remove(dom_html_select_element
*ele,
return err;
/* Ensure index is in range */
- if (index >= len)
+ if (index < 0 || (uint32_t)index >= len)
return DOM_NO_ERR;
err = dom_html_options_collection_item(ele->options, index, &option);
-----------------------------------------------------------------------
Summary of changes:
.gitignore | 1 -
include/dom/html/html_select_element.h | 2 +-
src/html/html_select_element.c | 4 ++--
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/.gitignore b/.gitignore
index a12a172..9d29615 100644
--- a/.gitignore
+++ b/.gitignore
@@ -3,5 +3,4 @@ build-*
build/docs
examples/dom-structure-dump
test/level*.c
-test/INDEX
*~
diff --git a/include/dom/html/html_select_element.h
b/include/dom/html/html_select_element.h
index 6999368..42aef00 100644
--- a/include/dom/html/html_select_element.h
+++ b/include/dom/html/html_select_element.h
@@ -80,7 +80,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element
*select,
(struct dom_html_element *) (e), \
(struct dom_html_element *) (b))
dom_exception dom_html_select_element_remove(dom_html_select_element *ele,
- long index);
+ int32_t index);
dom_exception dom_html_select_element_blur(struct dom_html_select_element *ele);
dom_exception dom_html_select_element_focus(struct dom_html_select_element *ele);
diff --git a/src/html/html_select_element.c b/src/html/html_select_element.c
index 4efffb9..12ea6ba 100644
--- a/src/html/html_select_element.c
+++ b/src/html/html_select_element.c
@@ -536,7 +536,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element
*select,
}
dom_exception dom_html_select_element_remove(dom_html_select_element *ele,
- long index)
+ int32_t index)
{
dom_exception err;
uint32_t len;
@@ -547,7 +547,7 @@ dom_exception dom_html_select_element_remove(dom_html_select_element
*ele,
return err;
/* Ensure index is in range */
- if (index >= len)
+ if (index < 0 || (uint32_t)index >= len)
return DOM_NO_ERR;
err = dom_html_options_collection_item(ele->options, index, &option);
--
Document Object Model library