Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/a5766db2b9516dbf02cf2...
...commit
http://git.netsurf-browser.org/netsurf.git/commit/a5766db2b9516dbf02cf2d0...
...tree
http://git.netsurf-browser.org/netsurf.git/tree/a5766db2b9516dbf02cf2d023...
The branch, master has been updated
via a5766db2b9516dbf02cf2d023d777aef4e0470c1 (commit)
from 813d0c70fe06090256b09356869f07e238c986a1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=a5766db2b9516dbf02c...
commit a5766db2b9516dbf02cf2d023d777aef4e0470c1
Author: Daniel Silverstone <dsilvers(a)digital-scurf.org>
Commit: Daniel Silverstone <dsilvers(a)digital-scurf.org>
fetchers/curl: Restrict AUTH to BASIC
cURL will prevent channel reuse if NTLM auth is enabled because
NTLM authenticates a channel not a request. As such we were
unable to reuse curl handles since we handed off connection
reuse to curl instead of our own handle cache. This mitigates
the effect, though curl authors are looking at fixing it upstream
too.
Fixes: #2707
Signed-off-by: Daniel Silverstone <dsilvers(a)digital-scurf.org>
diff --git a/content/fetchers/curl.c b/content/fetchers/curl.c
index f24e3de..2644c68 100644
--- a/content/fetchers/curl.c
+++ b/content/fetchers/curl.c
@@ -840,7 +840,7 @@ static CURLcode fetch_curl_set_options(struct curl_fetch_info *f)
}
if ((auth = urldb_get_auth_details(f->url, NULL)) != NULL) {
- SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_ANY);
+ SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_BASIC);
SETOPT(CURLOPT_USERPWD, auth);
} else {
SETOPT(CURLOPT_USERPWD, NULL);
-----------------------------------------------------------------------
Summary of changes:
content/fetchers/curl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/content/fetchers/curl.c b/content/fetchers/curl.c
index f24e3de..2644c68 100644
--- a/content/fetchers/curl.c
+++ b/content/fetchers/curl.c
@@ -840,7 +840,7 @@ static CURLcode fetch_curl_set_options(struct curl_fetch_info *f)
}
if ((auth = urldb_get_auth_details(f->url, NULL)) != NULL) {
- SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_ANY);
+ SETOPT(CURLOPT_HTTPAUTH, CURLAUTH_BASIC);
SETOPT(CURLOPT_USERPWD, auth);
} else {
SETOPT(CURLOPT_USERPWD, NULL);
--
NetSurf Browser