Gitweb links:
...log
http://git.netsurf-browser.org/netsurf.git/shortlog/3fc666a9be6bd9c8b1561...
...commit
http://git.netsurf-browser.org/netsurf.git/commit/3fc666a9be6bd9c8b15616c...
...tree
http://git.netsurf-browser.org/netsurf.git/tree/3fc666a9be6bd9c8b15616c60...
The branch, master has been updated
via 3fc666a9be6bd9c8b15616c60f332e1427a90f1d (commit)
from 4776f05430e1b8002e6ca6eec3e69f84fa130eda (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commitdiff
http://git.netsurf-browser.org/netsurf.git/commit/?id=3fc666a9be6bd9c8b15...
commit 3fc666a9be6bd9c8b15616c60f332e1427a90f1d
Author: Michael Drake <tlsa(a)netsurf-browser.org>
Commit: Michael Drake <tlsa(a)netsurf-browser.org>
Squash Coverity #1109879 - Resource leak.
diff --git a/render/box_construct.c b/render/box_construct.c
index cc30d89..3251cc1 100644
--- a/render/box_construct.c
+++ b/render/box_construct.c
@@ -2118,12 +2118,16 @@ bool box_create_frameset(struct content_html_frames *f, dom_node
*n,
if (err == DOM_NO_ERR && s != NULL) {
col_width = box_parse_multi_lengths(dom_string_data(s), &cols);
dom_string_unref(s);
- if (col_width == NULL)
+ if (col_width == NULL) {
+ free(row_height);
return false;
+ }
} else {
col_width = calloc(1, sizeof(struct frame_dimension));
- if (col_width == NULL)
+ if (col_width == NULL) {
+ free(row_height);
return false;
+ }
col_width->value = 100;
col_width->unit = FRAME_DIMENSION_PERCENT;
}
-----------------------------------------------------------------------
Summary of changes:
render/box_construct.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/render/box_construct.c b/render/box_construct.c
index cc30d89..3251cc1 100644
--- a/render/box_construct.c
+++ b/render/box_construct.c
@@ -2118,12 +2118,16 @@ bool box_create_frameset(struct content_html_frames *f, dom_node
*n,
if (err == DOM_NO_ERR && s != NULL) {
col_width = box_parse_multi_lengths(dom_string_data(s), &cols);
dom_string_unref(s);
- if (col_width == NULL)
+ if (col_width == NULL) {
+ free(row_height);
return false;
+ }
} else {
col_width = calloc(1, sizeof(struct frame_dimension));
- if (col_width == NULL)
+ if (col_width == NULL) {
+ free(row_height);
return false;
+ }
col_width->value = 100;
col_width->unit = FRAME_DIMENSION_PERCENT;
}
--
NetSurf Browser