April 2015 - netsurf-commits - listmaster.pepperfish.net

libwapcaplet: branch master updated. release/0.2.2-6-gc72138e

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/libwapcaplet.git/shortlog/c72138ebe3a5a09e... ...commit http://git.netsurf-browser.org/libwapcaplet.git/commit/c72138ebe3a5a09eab... ...tree http://git.netsurf-browser.org/libwapcaplet.git/tree/c72138ebe3a5a09eab1b... The branch, master has been updated via c72138ebe3a5a09eab1bc246232e03838686e941 (commit) from 4239c574e960de244cb46685ec24067cd1206dbe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/libwapcaplet.git/commit/?id=c72138ebe3a5a0... commit c72138ebe3a5a09eab1bc246232e03838686e941 Author: Michael Drake <tlsa(a)netsurf-browser.org> Commit: Michael Drake <tlsa(a)netsurf-browser.org> Fix build with gcc 4.9. diff --git a/test/basictests.c b/test/basictests.c index 6b5218d..ec9bf20 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -24,13 +24,13 @@ lwc_string **null_lwc_p = NULL; /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, null_lwc_p); + (void) lwc_intern_string(NULL, 0, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, null_lwc_p); + (void) lwc_intern_string("A", 1, null_lwc_p); } END_TEST @@ -64,19 +64,19 @@ END_TEST START_TEST (test_lwc_string_data_aborts) { - lwc_string_data(null_lwc); + (void) lwc_string_data(null_lwc); } END_TEST START_TEST (test_lwc_string_length_aborts) { - lwc_string_length(null_lwc); + (void) lwc_string_length(null_lwc); } END_TEST START_TEST (test_lwc_string_hash_value_aborts) { - lwc_string_hash_value(null_lwc); + (void) lwc_string_hash_value(null_lwc); } END_TEST ----------------------------------------------------------------------- Summary of changes: test/basictests.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/basictests.c b/test/basictests.c index 6b5218d..ec9bf20 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -24,13 +24,13 @@ lwc_string **null_lwc_p = NULL; /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, null_lwc_p); + (void) lwc_intern_string(NULL, 0, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, null_lwc_p); + (void) lwc_intern_string("A", 1, null_lwc_p); } END_TEST @@ -64,19 +64,19 @@ END_TEST START_TEST (test_lwc_string_data_aborts) { - lwc_string_data(null_lwc); + (void) lwc_string_data(null_lwc); } END_TEST START_TEST (test_lwc_string_length_aborts) { - lwc_string_length(null_lwc); + (void) lwc_string_length(null_lwc); } END_TEST START_TEST (test_lwc_string_hash_value_aborts) { - lwc_string_hash_value(null_lwc); + (void) lwc_string_hash_value(null_lwc); } END_TEST -- String internment library

7 years, 10 months

1
0
0 / 0

libwapcaplet: branch master updated. release/0.2.2-5-g4239c57

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/libwapcaplet.git/shortlog/4239c574e960de24... ...commit http://git.netsurf-browser.org/libwapcaplet.git/commit/4239c574e960de244c... ...tree http://git.netsurf-browser.org/libwapcaplet.git/tree/4239c574e960de244cb4... The branch, master has been updated via 4239c574e960de244cb46685ec24067cd1206dbe (commit) from fe1cf79a19ecf625bb46890f0ee497153e0376e0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/libwapcaplet.git/commit/?id=4239c574e960de... commit 4239c574e960de244cb46685ec24067cd1206dbe Author: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> Commit: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> Fix typo diff --git a/test/basictests.c b/test/basictests.c index 414a2be..6b5218d 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -58,7 +58,7 @@ END_TEST START_TEST (test_lwc_string_unref_aborts) { - lwc_string_unref(lwc_null); + lwc_string_unref(null_lwc); } END_TEST ----------------------------------------------------------------------- Summary of changes: test/basictests.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/basictests.c b/test/basictests.c index 414a2be..6b5218d 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -58,7 +58,7 @@ END_TEST START_TEST (test_lwc_string_unref_aborts) { - lwc_string_unref(lwc_null); + lwc_string_unref(null_lwc); } END_TEST -- String internment library

7 years, 10 months

1
0
0 / 0

libwapcaplet: branch master updated. release/0.2.2-4-gfe1cf79

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/libwapcaplet.git/shortlog/fe1cf79a19ecf625... ...commit http://git.netsurf-browser.org/libwapcaplet.git/commit/fe1cf79a19ecf625bb... ...tree http://git.netsurf-browser.org/libwapcaplet.git/tree/fe1cf79a19ecf625bb46... The branch, master has been updated via fe1cf79a19ecf625bb46890f0ee497153e0376e0 (commit) from 15b8c5717f9058871c187dcd63ea3586f58ad9d1 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/libwapcaplet.git/commit/?id=fe1cf79a19ecf6... commit fe1cf79a19ecf625bb46890f0ee497153e0376e0 Author: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> Commit: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> Fix up a couple of type hiccoughs diff --git a/test/basictests.c b/test/basictests.c index ee8b9b3..414a2be 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -19,23 +19,24 @@ #ifndef NDEBUG lwc_string *null_lwc = NULL; +lwc_string **null_lwc_p = NULL; /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, null_lwc); + lwc_intern_string(NULL, 0, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, null_lwc); + lwc_intern_string("A", 1, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_substring_aborts1) { - lwc_intern_substring(null_lwc, 0, 0, null_lwc); + lwc_intern_substring(null_lwc, 0, 0, null_lwc_p); } END_TEST @@ -45,7 +46,7 @@ START_TEST (test_lwc_intern_substring_aborts2) fail_unless(lwc_intern_string("Jam", 3, &str) == lwc_error_ok, "unable to intern 'Jam'"); - lwc_intern_substring(str, 88, 77, null_lwc); + lwc_intern_substring(str, 88, 77, null_lwc_p); } END_TEST ----------------------------------------------------------------------- Summary of changes: test/basictests.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/basictests.c b/test/basictests.c index ee8b9b3..414a2be 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -19,23 +19,24 @@ #ifndef NDEBUG lwc_string *null_lwc = NULL; +lwc_string **null_lwc_p = NULL; /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, null_lwc); + lwc_intern_string(NULL, 0, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, null_lwc); + lwc_intern_string("A", 1, null_lwc_p); } END_TEST START_TEST (test_lwc_intern_substring_aborts1) { - lwc_intern_substring(null_lwc, 0, 0, null_lwc); + lwc_intern_substring(null_lwc, 0, 0, null_lwc_p); } END_TEST @@ -45,7 +46,7 @@ START_TEST (test_lwc_intern_substring_aborts2) fail_unless(lwc_intern_string("Jam", 3, &str) == lwc_error_ok, "unable to intern 'Jam'"); - lwc_intern_substring(str, 88, 77, null_lwc); + lwc_intern_substring(str, 88, 77, null_lwc_p); } END_TEST -- String internment library

7 years, 10 months

1
0
0 / 0

libwapcaplet: branch master updated. release/0.2.2-3-g15b8c57

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/libwapcaplet.git/shortlog/15b8c5717f905887... ...commit http://git.netsurf-browser.org/libwapcaplet.git/commit/15b8c5717f9058871c... ...tree http://git.netsurf-browser.org/libwapcaplet.git/tree/15b8c5717f9058871c18... The branch, master has been updated via 15b8c5717f9058871c187dcd63ea3586f58ad9d1 (commit) from cb5ca6b62bb194e66c9d261fec8bde9f050544e6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/libwapcaplet.git/commit/?id=15b8c5717f9058... commit 15b8c5717f9058871c187dcd63ea3586f58ad9d1 Author: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> Commit: Daniel Silverstone <daniel.silverstone(a)codethink.co.uk> use null_lwc instead of NULL in a bunch of tests diff --git a/test/basictests.c b/test/basictests.c index 0024a8d..ee8b9b3 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -17,22 +17,25 @@ #endif #ifndef NDEBUG + +lwc_string *null_lwc = NULL; + /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, NULL); + lwc_intern_string(NULL, 0, null_lwc); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, NULL); + lwc_intern_string("A", 1, null_lwc); } END_TEST START_TEST (test_lwc_intern_substring_aborts1) { - lwc_intern_substring(NULL, 0, 0, NULL); + lwc_intern_substring(null_lwc, 0, 0, null_lwc); } END_TEST @@ -42,37 +45,37 @@ START_TEST (test_lwc_intern_substring_aborts2) fail_unless(lwc_intern_string("Jam", 3, &str) == lwc_error_ok, "unable to intern 'Jam'"); - lwc_intern_substring(str, 88, 77, NULL); + lwc_intern_substring(str, 88, 77, null_lwc); } END_TEST START_TEST (test_lwc_string_ref_aborts) { - lwc_string_ref(NULL); + lwc_string_ref(null_lwc); } END_TEST START_TEST (test_lwc_string_unref_aborts) { - lwc_string_unref(NULL); + lwc_string_unref(lwc_null); } END_TEST START_TEST (test_lwc_string_data_aborts) { - lwc_string_data(NULL); + lwc_string_data(null_lwc); } END_TEST START_TEST (test_lwc_string_length_aborts) { - lwc_string_length(NULL); + lwc_string_length(null_lwc); } END_TEST START_TEST (test_lwc_string_hash_value_aborts) { - lwc_string_hash_value(NULL); + lwc_string_hash_value(null_lwc); } END_TEST ----------------------------------------------------------------------- Summary of changes: test/basictests.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/test/basictests.c b/test/basictests.c index 0024a8d..ee8b9b3 100644 --- a/test/basictests.c +++ b/test/basictests.c @@ -17,22 +17,25 @@ #endif #ifndef NDEBUG + +lwc_string *null_lwc = NULL; + /* All the basic assert() tests */ START_TEST (test_lwc_intern_string_aborts1) { - lwc_intern_string(NULL, 0, NULL); + lwc_intern_string(NULL, 0, null_lwc); } END_TEST START_TEST (test_lwc_intern_string_aborts2) { - lwc_intern_string("A", 1, NULL); + lwc_intern_string("A", 1, null_lwc); } END_TEST START_TEST (test_lwc_intern_substring_aborts1) { - lwc_intern_substring(NULL, 0, 0, NULL); + lwc_intern_substring(null_lwc, 0, 0, null_lwc); } END_TEST @@ -42,37 +45,37 @@ START_TEST (test_lwc_intern_substring_aborts2) fail_unless(lwc_intern_string("Jam", 3, &str) == lwc_error_ok, "unable to intern 'Jam'"); - lwc_intern_substring(str, 88, 77, NULL); + lwc_intern_substring(str, 88, 77, null_lwc); } END_TEST START_TEST (test_lwc_string_ref_aborts) { - lwc_string_ref(NULL); + lwc_string_ref(null_lwc); } END_TEST START_TEST (test_lwc_string_unref_aborts) { - lwc_string_unref(NULL); + lwc_string_unref(lwc_null); } END_TEST START_TEST (test_lwc_string_data_aborts) { - lwc_string_data(NULL); + lwc_string_data(null_lwc); } END_TEST START_TEST (test_lwc_string_length_aborts) { - lwc_string_length(NULL); + lwc_string_length(null_lwc); } END_TEST START_TEST (test_lwc_string_hash_value_aborts) { - lwc_string_hash_value(NULL); + lwc_string_hash_value(null_lwc); } END_TEST -- String internment library

7 years, 10 months

1
0
0 / 0

buildsystem: branch master updated. release/1.3-6-g6548d56

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/buildsystem.git/shortlog/6548d564fd7579580... ...commit http://git.netsurf-browser.org/buildsystem.git/commit/6548d564fd75795806e... ...tree http://git.netsurf-browser.org/buildsystem.git/tree/6548d564fd75795806ee9... The branch, master has been updated via 6548d564fd75795806ee9f9e7c6abaa43e56cdf5 (commit) from 85a1a7673f7dda152f1209891bdacfabe0bfa39d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/buildsystem.git/commit/?id=6548d564fd75795... commit 6548d564fd75795806ee9f9e7c6abaa43e56cdf5 Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> make coverage builds not fail on warning diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index ae2dfec..2646427 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -153,7 +153,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} # build as per type requested if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build - ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage + CFLAGS=-Wno-error ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage gcovr -x -r build-${BUILD}-${HOST}-${VARIANT}-lib-static -o coverage.xml ----------------------------------------------------------------------- Summary of changes: citools/jenkins-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index ae2dfec..2646427 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -153,7 +153,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} # build as per type requested if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build - ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage + CFLAGS=-Wno-error ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage gcovr -x -r build-${BUILD}-${HOST}-${VARIANT}-lib-static -o coverage.xml -- NetSurf Project build system

7 years, 10 months

1
0
0 / 0

netsurf: branch master updated. release/3.3-129-g2aef095

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/netsurf.git/shortlog/2aef095f27e55600f6cbd... ...commit http://git.netsurf-browser.org/netsurf.git/commit/2aef095f27e55600f6cbdf6... ...tree http://git.netsurf-browser.org/netsurf.git/tree/2aef095f27e55600f6cbdf6f3... The branch, master has been updated via 2aef095f27e55600f6cbdf6f3d4c4f1fe584f07b (commit) via 05538c0264db8ba117248f481e769f62969dc82b (commit) from c6a6c8e7faa9165d5337e61c6bd331071367cec0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=2aef095f27e55600f6c... commit 2aef095f27e55600f6cbdf6f3d4c4f1fe584f07b Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> Ensure bandwidth minimum check is only performed when enough data has been written. diff --git a/content/llcache.c b/content/llcache.c index 2267f8f..9628fd3 100644 --- a/content/llcache.c +++ b/content/llcache.c @@ -2427,17 +2427,26 @@ write_backing_store(struct llcache_object *object, * If the overall write bandwidth has fallen below a useful level for * the backing store to be effective disable it. * + * It is important to ensure a useful amount of data has been written + * before calculating bandwidths otherwise tiny files taking a + * disproportionately long time to write might trigger this erroneously. + * * \param p The context pointer passed to the callback. */ static void llcache_persist_slowcheck(void *p) { - unsigned long total_bandwidth; /* total bandwidth */ - total_bandwidth = (llcache->total_written * 1000) / llcache->total_elapsed; + uint64_t total_bandwidth; /* total bandwidth */ + + if (llcache->total_written > (2 * llcache->minimum_bandwidth)) { - if (total_bandwidth < llcache->minimum_bandwidth) { - LOG(("Cannot write minimum bandwidth")); - warn_user("LowDiscWriteBandwidth", 0); - guit->llcache->finalise(); + total_bandwidth = (llcache->total_written * 1000) / llcache->total_elapsed; + + if (total_bandwidth < llcache->minimum_bandwidth) { + LOG(("Current bandwidth %llu less than minimum %llu", + total_bandwidth, llcache->minimum_bandwidth)); + warn_user("LowDiscWriteBandwidth", 0); + guit->llcache->finalise(); + } } } commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=05538c0264db8ba1172... commit 05538c0264db8ba117248f481e769f62969dc82b Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> Ensure small block cache files allocate their entire extent at open. It seems many filesystems are greatly more efficient if the block file is allocated its entire extent once rather than trying to continuously grown the file later. The size of the block files is known at their creation time so this change ensures they are grown to the full possible extent hence removing future inefficient writes. diff --git a/content/fs_backing_store.c b/content/fs_backing_store.c index d23a9d1..2a5b3ea 100644 --- a/content/fs_backing_store.c +++ b/content/fs_backing_store.c @@ -31,8 +31,6 @@ * lifetime is typically very short, though this may be obsoleted * by a small object storage stratagy. * - * \todo make backing store have a more efficient small object storage. - * */ #include <unistd.h> @@ -1591,9 +1589,14 @@ static nserror store_write_block(struct store_state *state, if (state->blocks[elem_idx][bf].fd == -1) { state->blocks[elem_idx][bf].fd = store_open(state, bf, elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); - } - if (state->blocks[elem_idx][bf].fd == -1) { - return NSERROR_SAVE_FAILED; + if (state->blocks[elem_idx][bf].fd == -1) { + LOG(("Open failed errno %d", errno)); + return NSERROR_SAVE_FAILED; + } + + /* ensure block file is correct length at open */ + ftruncate(state->blocks[elem_idx][bf].fd, + 1U << (log2_block_size[elem_idx] + BLOCK_ENTRY_COUNT)); } offst = bi << log2_block_size[elem_idx]; @@ -1745,11 +1748,16 @@ static nserror store_read_block(struct store_state *state, /* ensure the block file fd is good */ if (state->blocks[elem_idx][bf].fd == -1) { - state->blocks[elem_idx][bf].fd = store_open(state, bf, elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); - } - if (state->blocks[elem_idx][bf].fd == -1) { - LOG(("Open failed errno %d", errno)); - return NSERROR_SAVE_FAILED; + state->blocks[elem_idx][bf].fd = store_open(state, bf, + elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); + if (state->blocks[elem_idx][bf].fd == -1) { + LOG(("Open failed errno %d", errno)); + return NSERROR_SAVE_FAILED; + } + + /* ensure block file is correct length at open */ + ftruncate(state->blocks[elem_idx][bf].fd, + 1U << (log2_block_size[elem_idx] + BLOCK_ENTRY_COUNT)); } offst = bi << log2_block_size[elem_idx]; ----------------------------------------------------------------------- Summary of changes: content/fs_backing_store.c | 28 ++++++++++++++++++---------- content/llcache.c | 21 +++++++++++++++------ 2 files changed, 33 insertions(+), 16 deletions(-) diff --git a/content/fs_backing_store.c b/content/fs_backing_store.c index d23a9d1..2a5b3ea 100644 --- a/content/fs_backing_store.c +++ b/content/fs_backing_store.c @@ -31,8 +31,6 @@ * lifetime is typically very short, though this may be obsoleted * by a small object storage stratagy. * - * \todo make backing store have a more efficient small object storage. - * */ #include <unistd.h> @@ -1591,9 +1589,14 @@ static nserror store_write_block(struct store_state *state, if (state->blocks[elem_idx][bf].fd == -1) { state->blocks[elem_idx][bf].fd = store_open(state, bf, elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); - } - if (state->blocks[elem_idx][bf].fd == -1) { - return NSERROR_SAVE_FAILED; + if (state->blocks[elem_idx][bf].fd == -1) { + LOG(("Open failed errno %d", errno)); + return NSERROR_SAVE_FAILED; + } + + /* ensure block file is correct length at open */ + ftruncate(state->blocks[elem_idx][bf].fd, + 1U << (log2_block_size[elem_idx] + BLOCK_ENTRY_COUNT)); } offst = bi << log2_block_size[elem_idx]; @@ -1745,11 +1748,16 @@ static nserror store_read_block(struct store_state *state, /* ensure the block file fd is good */ if (state->blocks[elem_idx][bf].fd == -1) { - state->blocks[elem_idx][bf].fd = store_open(state, bf, elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); - } - if (state->blocks[elem_idx][bf].fd == -1) { - LOG(("Open failed errno %d", errno)); - return NSERROR_SAVE_FAILED; + state->blocks[elem_idx][bf].fd = store_open(state, bf, + elem_idx + ENTRY_ELEM_COUNT, O_CREAT | O_RDWR); + if (state->blocks[elem_idx][bf].fd == -1) { + LOG(("Open failed errno %d", errno)); + return NSERROR_SAVE_FAILED; + } + + /* ensure block file is correct length at open */ + ftruncate(state->blocks[elem_idx][bf].fd, + 1U << (log2_block_size[elem_idx] + BLOCK_ENTRY_COUNT)); } offst = bi << log2_block_size[elem_idx]; diff --git a/content/llcache.c b/content/llcache.c index 2267f8f..9628fd3 100644 --- a/content/llcache.c +++ b/content/llcache.c @@ -2427,17 +2427,26 @@ write_backing_store(struct llcache_object *object, * If the overall write bandwidth has fallen below a useful level for * the backing store to be effective disable it. * + * It is important to ensure a useful amount of data has been written + * before calculating bandwidths otherwise tiny files taking a + * disproportionately long time to write might trigger this erroneously. + * * \param p The context pointer passed to the callback. */ static void llcache_persist_slowcheck(void *p) { - unsigned long total_bandwidth; /* total bandwidth */ - total_bandwidth = (llcache->total_written * 1000) / llcache->total_elapsed; + uint64_t total_bandwidth; /* total bandwidth */ + + if (llcache->total_written > (2 * llcache->minimum_bandwidth)) { - if (total_bandwidth < llcache->minimum_bandwidth) { - LOG(("Cannot write minimum bandwidth")); - warn_user("LowDiscWriteBandwidth", 0); - guit->llcache->finalise(); + total_bandwidth = (llcache->total_written * 1000) / llcache->total_elapsed; + + if (total_bandwidth < llcache->minimum_bandwidth) { + LOG(("Current bandwidth %llu less than minimum %llu", + total_bandwidth, llcache->minimum_bandwidth)); + warn_user("LowDiscWriteBandwidth", 0); + guit->llcache->finalise(); + } } } -- NetSurf Browser

7 years, 10 months

1
0
0 / 0

buildsystem: branch master updated. release/1.3-5-g85a1a76

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/buildsystem.git/shortlog/85a1a7673f7dda152... ...commit http://git.netsurf-browser.org/buildsystem.git/commit/85a1a7673f7dda152f1... ...tree http://git.netsurf-browser.org/buildsystem.git/tree/85a1a7673f7dda152f120... The branch, master has been updated via 85a1a7673f7dda152f1209891bdacfabe0bfa39d (commit) from 12e8dfbfc478bc6d2f8f29466a1e793b86ccf3be (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/buildsystem.git/commit/?id=85a1a7673f7dda1... commit 85a1a7673f7dda152f1209891bdacfabe0bfa39d Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> Try different approach to get coverage conversion correct diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index 866afb3..ae2dfec 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r build-${HOST}-${VARIANT}-lib-static -o coverage.xml + gcovr -x -r build-${BUILD}-${HOST}-${VARIANT}-lib-static -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then ----------------------------------------------------------------------- Summary of changes: citools/jenkins-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index 866afb3..ae2dfec 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r build-${HOST}-${VARIANT}-lib-static -o coverage.xml + gcovr -x -r build-${BUILD}-${HOST}-${VARIANT}-lib-static -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then -- NetSurf Project build system

7 years, 10 months

1
0
0 / 0

buildsystem: branch master updated. release/1.3-4-g12e8dfb

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/buildsystem.git/shortlog/12e8dfbfc478bc6d2... ...commit http://git.netsurf-browser.org/buildsystem.git/commit/12e8dfbfc478bc6d2f8... ...tree http://git.netsurf-browser.org/buildsystem.git/tree/12e8dfbfc478bc6d2f8f2... The branch, master has been updated via 12e8dfbfc478bc6d2f8f29466a1e793b86ccf3be (commit) from 2b05492d78c439ecb679f1e3721ba65a909ad054 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/buildsystem.git/commit/?id=12e8dfbfc478bc6... commit 12e8dfbfc478bc6d2f8f29466a1e793b86ccf3be Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> correct the expansion of the target directory for gcov conversion diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index e831ce2..866afb3 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r build-${BUILD}-${HOST}-${VARIANT} -o coverage.xml + gcovr -x -r build-${HOST}-${VARIANT}-lib-static -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then ----------------------------------------------------------------------- Summary of changes: citools/jenkins-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index e831ce2..866afb3 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r build-${BUILD}-${HOST}-${VARIANT} -o coverage.xml + gcovr -x -r build-${HOST}-${VARIANT}-lib-static -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then -- NetSurf Project build system

7 years, 10 months

1
0
0 / 0

buildsystem: branch master updated. release/1.3-3-g2b05492

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/buildsystem.git/shortlog/2b05492d78c439ecb... ...commit http://git.netsurf-browser.org/buildsystem.git/commit/2b05492d78c439ecb67... ...tree http://git.netsurf-browser.org/buildsystem.git/tree/2b05492d78c439ecb679f... The branch, master has been updated via 2b05492d78c439ecb679f1e3721ba65a909ad054 (commit) from ba62b2b494f7ec7fef9d0936cbef7bdeaa80e2fc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/buildsystem.git/commit/?id=2b05492d78c439e... commit 2b05492d78c439ecb679f1e3721ba65a909ad054 Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> Set the gcov coverage conversion to the correct source root diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index 7be5d46..e831ce2 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r . -o coverage.xml + gcovr -x -r build-${BUILD}-${HOST}-${VARIANT} -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then ----------------------------------------------------------------------- Summary of changes: citools/jenkins-build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/citools/jenkins-build.sh b/citools/jenkins-build.sh index 7be5d46..e831ce2 100755 --- a/citools/jenkins-build.sh +++ b/citools/jenkins-build.sh @@ -154,7 +154,7 @@ ${MAKE} Q= clean HOST=${HOST} VARIANT=${VARIANT} if [ "x${HOST}" = "x${TARGET_COVERAGE}" ]; then # Coverage Build ${MAKE} Q= HOST=${HOST} VARIANT=${VARIANT} coverage - gcovr -x -r . -o coverage.xml + gcovr -x -r build-${BUILD}-${HOST}-${VARIANT} -o coverage.xml elif [ "x${HOST}" = "x${TARGET_STATIC}" ]; then -- NetSurf Project build system

7 years, 10 months

1
0
0 / 0

netsurf: branch master updated. release/3.3-127-gc6a6c8e

by NetSurf Browser Project

Gitweb links: ...log http://git.netsurf-browser.org/netsurf.git/shortlog/c6a6c8e7faa9165d5337e... ...commit http://git.netsurf-browser.org/netsurf.git/commit/c6a6c8e7faa9165d5337e61... ...tree http://git.netsurf-browser.org/netsurf.git/tree/c6a6c8e7faa9165d5337e61c6... The branch, master has been updated via c6a6c8e7faa9165d5337e61c6bd331071367cec0 (commit) from 55f8a41cfe2e5570c62e94d42e5f579daec31e4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commitdiff http://git.netsurf-browser.org/netsurf.git/commit/?id=c6a6c8e7faa9165d533... commit c6a6c8e7faa9165d5337e61c6bd331071367cec0 Author: Vincent Sanders <vince(a)kyllikki.org> Commit: Vincent Sanders <vince(a)kyllikki.org> Remove unecessary dll from windows installer script diff --git a/windows/res/installer.nsi b/windows/res/installer.nsi index 1b4ed96..a934533 100644 --- a/windows/res/installer.nsi +++ b/windows/res/installer.nsi @@ -58,8 +58,6 @@ section "install" # Files added here should be removed by the uninstaller (see section "uninstall") file "NetSurf.exe" file /oname=NetSurf.ico "windows\res\NetSurf.ico" - file /oname=libcares-2.dll "/opt/netsurf/i686-w64-mingw32/env/bin/libcares-2.dll" - file /oname=libgnurx-0.dll "/opt/netsurf/i686-w64-mingw32/env/bin/libgnurx-0.dll" file /oname=default.css "windows\res\default.css" file /oname=welcome.html "windows\res\welcome.html" file /oname=netsurf.png "windows\res\netsurf.png" ----------------------------------------------------------------------- Summary of changes: windows/res/installer.nsi | 2 -- 1 file changed, 2 deletions(-) diff --git a/windows/res/installer.nsi b/windows/res/installer.nsi index 1b4ed96..a934533 100644 --- a/windows/res/installer.nsi +++ b/windows/res/installer.nsi @@ -58,8 +58,6 @@ section "install" # Files added here should be removed by the uninstaller (see section "uninstall") file "NetSurf.exe" file /oname=NetSurf.ico "windows\res\NetSurf.ico" - file /oname=libcares-2.dll "/opt/netsurf/i686-w64-mingw32/env/bin/libcares-2.dll" - file /oname=libgnurx-0.dll "/opt/netsurf/i686-w64-mingw32/env/bin/libgnurx-0.dll" file /oname=default.css "windows\res\default.css" file /oname=welcome.html "windows\res\welcome.html" file /oname=netsurf.png "windows\res\netsurf.png" -- NetSurf Browser

7 years, 10 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

netsurf-commits April 2015