November 2009 - netsurf-commits - listmaster.pepperfish.net

r9679 jmb - /trunk/netsurf/desktop/selection.c

by netsurf＠semichrome.net

Author: jmb Date: Sun Nov 22 07:20:39 2009 New Revision: 9679 URL: http://source.netsurf-browser.org?rev=9679&view=rev Log: Ensure selection context is zero-initialised. This may well be the root cause of the random selection crashes people have been seeing. Modified: trunk/netsurf/desktop/selection.c Modified: trunk/netsurf/desktop/selection.c URL: http://source.netsurf-browser.org/trunk/netsurf/desktop/selection.c?rev=9... ============================================================================== --- trunk/netsurf/desktop/selection.c (original) +++ trunk/netsurf/desktop/selection.c Sun Nov 22 07:20:39 2009 @@ -91,7 +91,7 @@ struct selection *selection_create(struct browser_window *bw) { - struct selection *s = malloc(sizeof(struct selection)); + struct selection *s = calloc(1, sizeof(struct selection)); if (s) { s->bw = bw; s->root = NULL;

13 years, 6 months

1
0
0 / 0

r9678 jmb - in /trunk/libcss/src: parse/language.h parse/parse.c parse/properties/font.c parse/properties/generated_list.c parse/properties/utils.c select/select.c

by netsurf＠semichrome.net

Author: jmb Date: Sun Nov 22 07:03:21 2009 New Revision: 9678 URL: http://source.netsurf-browser.org?rev=9678&view=rev Log: Lose redundant assignments. Drop some dead code. Avoid a potential NULL dereference. Add missing "break" in initial substate of block context parser Modified: trunk/libcss/src/parse/language.h trunk/libcss/src/parse/parse.c trunk/libcss/src/parse/properties/font.c trunk/libcss/src/parse/properties/generated_list.c trunk/libcss/src/parse/properties/utils.c trunk/libcss/src/select/select.c Modified: trunk/libcss/src/parse/language.h URL: http://source.netsurf-browser.org/trunk/libcss/src/parse/language.h?rev=9... ============================================================================== --- trunk/libcss/src/parse/language.h (original) +++ trunk/libcss/src/parse/language.h Sun Nov 22 07:03:21 2009 @@ -61,7 +61,7 @@ while ((token = parserutils_vector_peek(vector, *ctx)) != NULL && token->type == CSS_TOKEN_S) - token = parserutils_vector_iterate(vector, ctx); + parserutils_vector_iterate(vector, ctx); } /** Modified: trunk/libcss/src/parse/parse.c URL: http://source.netsurf-browser.org/trunk/libcss/src/parse/parse.c?rev=9678... ============================================================================== --- trunk/libcss/src/parse/parse.c (original) +++ trunk/libcss/src/parse/parse.c Sun Nov 22 07:03:21 2009 @@ -1448,6 +1448,8 @@ return transition(parser, to, subsequent); } + + break; case WS: error = eatWS(parser); if (error != CSS_OK) Modified: trunk/libcss/src/parse/properties/font.c URL: http://source.netsurf-browser.org/trunk/libcss/src/parse/properties/font.... ============================================================================== --- trunk/libcss/src/parse/properties/font.c (original) +++ trunk/libcss/src/parse/properties/font.c Sun Nov 22 07:03:21 2009 @@ -117,8 +117,6 @@ if (error == CSS_OK) { consumeWhitespace(vector, ctx); - - token = parserutils_vector_peek(vector, *ctx); } else { break; } Modified: trunk/libcss/src/parse/properties/generated_list.c URL: http://source.netsurf-browser.org/trunk/libcss/src/parse/properties/gener... ============================================================================== --- trunk/libcss/src/parse/properties/generated_list.c (original) +++ trunk/libcss/src/parse/properties/generated_list.c Sun Nov 22 07:03:21 2009 @@ -671,7 +671,7 @@ close = token->idata; - token = parserutils_vector_iterate(vector, &temp_ctx); + parserutils_vector_iterate(vector, &temp_ctx); consumeWhitespace(vector, &temp_ctx); @@ -736,7 +736,7 @@ close = token->idata; - token = parserutils_vector_iterate(vector, ctx); + parserutils_vector_iterate(vector, ctx); consumeWhitespace(vector, ctx); Modified: trunk/libcss/src/parse/properties/utils.c URL: http://source.netsurf-browser.org/trunk/libcss/src/parse/properties/utils... ============================================================================== --- trunk/libcss/src/parse/properties/utils.c (original) +++ trunk/libcss/src/parse/properties/utils.c Sun Nov 22 07:03:21 2009 @@ -48,8 +48,8 @@ token->type != CSS_TOKEN_HASH && token->type != CSS_TOKEN_FUNCTION)) { if (c->sheet->quirks_allowed == false || - (token != NULL && - token->type != CSS_TOKEN_NUMBER && + token == NULL || + (token->type != CSS_TOKEN_NUMBER && token->type != CSS_TOKEN_DIMENSION)) goto invalid; } Modified: trunk/libcss/src/select/select.c URL: http://source.netsurf-browser.org/trunk/libcss/src/select/select.c?rev=96... ============================================================================== --- trunk/libcss/src/select/select.c (original) +++ trunk/libcss/src/select/select.c Sun Nov 22 07:03:21 2009 @@ -417,9 +417,6 @@ /* Retrieve this property's hint from the client */ error = state->handler->node_presentational_hint(state->pw, state->node, i, &hint); - if (error != CSS_OK && error != CSS_PROPERTY_NOT_SET) - return error; - if (error != CSS_OK) return (error == CSS_PROPERTY_NOT_SET) ? CSS_OK : error;

13 years, 6 months

1
0
0 / 0

r9677 chris_y - in /trunk/netsurf/amiga: download.c gui.c object.c

by netsurf＠semichrome.net

Author: chris_y Date: Sun Nov 15 17:11:41 2009 New Revision: 9677 URL: http://source.netsurf-browser.org?rev=9677&view=rev Log: Fix some potential issues with lists not being freed properly Modified: trunk/netsurf/amiga/download.c trunk/netsurf/amiga/gui.c trunk/netsurf/amiga/object.c Modified: trunk/netsurf/amiga/download.c URL: http://source.netsurf-browser.org/trunk/netsurf/amiga/download.c?rev=9677... ============================================================================== --- trunk/netsurf/amiga/download.c (original) +++ trunk/netsurf/amiga/download.c Sun Nov 15 17:11:41 2009 @@ -224,17 +224,19 @@ struct dlnode *node; struct dlnode *nnode; + if(!dllist) return; + if(IsListEmpty(dllist)) return; + node = (struct dlnode *)GetHead((struct List *)dllist); - while(nnode=(struct dlnode *)GetSucc((struct Node *)node)) - { + do + { + nnode=(struct dlnode *)GetSucc((struct Node *)node); free(node->node.ln_Name); free(node->filename); Remove((struct Node *)node); FreeVec((struct Node *)node); - - node=nnode; - } + }while(node=nnode); } void gui_window_save_as_link(struct gui_window *g, struct content *c) Modified: trunk/netsurf/amiga/gui.c URL: http://source.netsurf-browser.org/trunk/netsurf/amiga/gui.c?rev=9677&r1=9... ============================================================================== --- trunk/netsurf/amiga/gui.c (original) +++ trunk/netsurf/amiga/gui.c Sun Nov 15 17:11:41 2009 @@ -1812,7 +1812,6 @@ ami_close_all_tabs(gwin); break; } - node = nnode; } while(node = nnode); } Modified: trunk/netsurf/amiga/object.c URL: http://source.netsurf-browser.org/trunk/netsurf/amiga/object.c?rev=9677&r... ============================================================================== --- trunk/netsurf/amiga/object.c (original) +++ trunk/netsurf/amiga/object.c Sun Nov 15 17:11:41 2009 @@ -61,17 +61,18 @@ struct nsObject *node; struct nsObject *nnode; + if(IsMinListEmpty(objlist)) return; node = (struct nsObject *)GetHead((struct List *)objlist); - while(nnode=(struct nsObject *)GetSucc((struct Node *)node)) + do { + nnode=(struct nsObject *)GetSucc((struct Node *)node); if(node->Type == AMINS_CALLBACK) ami_remove_timer_event((struct nscallback *)node->objstruct); DelObject(node); - - node=nnode; - } + + }while(node=nnode); FreeVec(objlist); }

13 years, 6 months

1
0
0 / 0

r9676 bursa - /trunk/libsvgtiny/svgtiny_display

by netsurf＠semichrome.net

Author: bursa Date: Sun Nov 15 17:02:06 2009 New Revision: 9676 URL: http://source.netsurf-browser.org?rev=9676&view=rev Log: Fix svgtiny_display script to work with new makefiles. Modified: trunk/libsvgtiny/svgtiny_display Modified: trunk/libsvgtiny/svgtiny_display URL: http://source.netsurf-browser.org/trunk/libsvgtiny/svgtiny_display?rev=96... ============================================================================== --- trunk/libsvgtiny/svgtiny_display (original) +++ trunk/libsvgtiny/svgtiny_display Sun Nov 15 17:02:06 2009 @@ -1,3 +1,3 @@ set -e -make -bin/svgtiny_test $1 $2 | convert mvg:- png:- | display - +make test +build-Linux-Linux-release-lib-static/test_svgtiny_test $1 $2 | convert mvg:- png:- | display -

13 years, 6 months

1
0
0 / 0

r9675 jmb - /trunk/netsurf/render/box_construct.c

by netsurf＠semichrome.net

Author: jmb Date: Sun Nov 15 04:10:00 2009 New Revision: 9675 URL: http://source.netsurf-browser.org?rev=9675&view=rev Log: Fix quirks mode propagation for @style. Modified: trunk/netsurf/render/box_construct.c Modified: trunk/netsurf/render/box_construct.c URL: http://source.netsurf-browser.org/trunk/netsurf/render/box_construct.c?re... ============================================================================== --- trunk/netsurf/render/box_construct.c (original) +++ trunk/netsurf/render/box_construct.c Sun Nov 15 04:10:00 2009 @@ -841,7 +841,8 @@ if ((s = (char *) xmlGetProp(n, (const xmlChar *) "style"))) { inline_style = nscss_create_inline_style( (uint8_t *) s, strlen(s), - c->data.html.encoding, c->url, false, + c->data.html.encoding, c->url, + c->data.html.quirks != BINDING_QUIRKS_MODE_NONE, c->data.html.dict, myrealloc, c); xmlFree(s);

13 years, 6 months

1
0
0 / 0

r9674 MarkieB - /branches/MarkieB/windows/windows/gui.c

by netsurf＠semichrome.net

Author: MarkieB Date: Fri Nov 13 00:25:44 2009 New Revision: 9674 URL: http://source.netsurf-browser.org?rev=9674&view=rev Log: add commentary in case anybody else is observing immediate window close at netsurf launch in real/virtual windows Modified: branches/MarkieB/windows/windows/gui.c Modified: branches/MarkieB/windows/windows/gui.c URL: http://source.netsurf-browser.org/branches/MarkieB/windows/windows/gui.c?... ============================================================================== --- branches/MarkieB/windows/windows/gui.c (original) +++ branches/MarkieB/windows/windows/gui.c Fri Nov 13 00:25:44 2009 @@ -1613,6 +1613,16 @@ { unsigned int listid = 0; char imagepath[PATH_MAX]; + /* NB there is currently an immediate window close at + * netsurf launch in real/virtual - as distinct from + * emulation - windows whose probable cause is the + * location of the url bar to the right of the buttons; + * really the way forward would quite possibly be to + * implement an active bitmap as the button bar, sensitive + * to hover / click events; the immediate window close + * behaviour was observed during development when testing + * the arrangements of url bar / buttons although much has + * changed since then */ HWND hwnd = CreateWindow(TOOLBARCLASSNAME, NULL, WS_CHILD | WS_VISIBLE | WS_BORDER | WS_CLIPSIBLINGS,

13 years, 6 months

1
0
0 / 0

r9673 jmb - /trunk/tools/buildsystem/makefiles/Makefile.tools

by netsurf＠semichrome.net

Author: jmb Date: Mon Nov 9 14:27:47 2009 New Revision: 9673 URL: http://source.netsurf-browser.org?rev=9673&view=rev Log: Actually, we need to make the host tooling the same as the target's in the case where host==target. Otherwise, default to cc/c++. Modified: trunk/tools/buildsystem/makefiles/Makefile.tools Modified: trunk/tools/buildsystem/makefiles/Makefile.tools URL: http://source.netsurf-browser.org/trunk/tools/buildsystem/makefiles/Makef... ============================================================================== --- trunk/tools/buildsystem/makefiles/Makefile.tools (original) +++ trunk/tools/buildsystem/makefiles/Makefile.tools Mon Nov 9 14:27:47 2009 @@ -184,9 +184,15 @@ GENHTML ?= genhtml -HOST_CC ?= cc - -HOST_CXX ?= c++ +ifeq ($(HOST),$(TARGET)) + HOST_CC ?= $(CC) + + HOST_CXX ?= $(CXX) +else + HOST_CC ?= cc + + HOST_CXX ?= c++ +endif INSTALL ?= install

13 years, 6 months

1
0
0 / 0

r9672 jmb - /trunk/tools/buildsystem/makefiles/Makefile.tools

by netsurf＠semichrome.net

Author: jmb Date: Mon Nov 9 14:24:59 2009 New Revision: 9672 URL: http://source.netsurf-browser.org?rev=9672&view=rev Log: If $(CC) is defaulted, use $(CC__) to determine EXEEXT. Default host tooling to cc/c++, rather than $(CC)/$(CXX) (which are the target toolchain) Modified: trunk/tools/buildsystem/makefiles/Makefile.tools Modified: trunk/tools/buildsystem/makefiles/Makefile.tools URL: http://source.netsurf-browser.org/trunk/tools/buildsystem/makefiles/Makef... ============================================================================== --- trunk/tools/buildsystem/makefiles/Makefile.tools (original) +++ trunk/tools/buildsystem/makefiles/Makefile.tools Mon Nov 9 14:24:59 2009 @@ -98,10 +98,18 @@ PKGCONFIG ?= $(GCCSDK_INSTALL_ENV)/ro-pkg-config ifneq ($(COMPONENT_TYPE),riscos-module) - ifneq ($(findstring arm-unknown-riscos-gcc,$(CC)),) - EXEEXT := ,e1f + ifeq ($(origin CC),default) + ifneq ($(findstring arm-unknown-riscos-gcc,$(CC__)),) + EXEEXT := ,e1f + else + EXEEXT := ,ff8 + endif else - EXEEXT := ,ff8 + ifneq ($(findstring arm-unknown-riscos-gcc,$(CC)),) + EXEEXT := ,e1f + else + EXEEXT := ,ff8 + endif endif else EXEEXT := ,ffa @@ -176,9 +184,9 @@ GENHTML ?= genhtml -HOST_CC ?= $(CC) - -HOST_CXX ?= $(CXX) +HOST_CC ?= cc + +HOST_CXX ?= c++ INSTALL ?= install

13 years, 6 months

1
0
0 / 0

r9671 jmb - /trunk/libwapcaplet/Makefile

by netsurf＠semichrome.net

Author: jmb Date: Fri Nov 6 01:05:53 2009 New Revision: 9671 URL: http://source.netsurf-browser.org?rev=9671&view=rev Log: -Wextra is only understood by GCC 3.4.6 or later. It is a more descriptive synonym for -W. Use -W instead which is understood by all common versions of GCC (i.e. GCC 2.95 supports it, which is the oldest GCC version we have to support) Additionally, conditionalise our -Werror usage on whether we're building for BeOS/Haiku. On these platforms, the standard library headers result in warnings. GCC 2 is quite happy to build this code on other platforms, so shouldn't be the trigger for dropping -Werror (even if BeOS is the only target where GCC2 is likely to be used). Modified: trunk/libwapcaplet/Makefile Modified: trunk/libwapcaplet/Makefile URL: http://source.netsurf-browser.org/trunk/libwapcaplet/Makefile?rev=9671&r1... ============================================================================== --- trunk/libwapcaplet/Makefile (original) +++ trunk/libwapcaplet/Makefile Fri Nov 6 01:05:53 2009 @@ -11,11 +11,12 @@ TESTRUNNER = $(BUILDDIR)/test_testrunner$(EXEEXT) # Toolchain flags -WARNFLAGS := -Wall -Wundef -Wpointer-arith -Wcast-align \ +WARNFLAGS := -Wall -W -Wundef -Wpointer-arith -Wcast-align \ -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \ - -Wmissing-declarations -Wnested-externs -Werror -pedantic -ifneq ($(GCCVER),2) - WARNFLAGS := $(WARNFLAGS) -Wextra + -Wmissing-declarations -Wnested-externs -pedantic +# BeOS/Haiku standard library headers issue warnings +ifneq ($(TARGET),beos) + WARNFLAGS := $(WARNFLAGS) -Werror endif CFLAGS := -D_BSD_SOURCE -I$(CURDIR)/include/ \ -I$(CURDIR)/src $(WARNFLAGS) $(CFLAGS)

13 years, 6 months

1
0
0 / 0

r9670 jmb - /trunk/libsvgtiny/Makefile

by netsurf＠semichrome.net

Author: jmb Date: Fri Nov 6 01:05:12 2009 New Revision: 9670 URL: http://source.netsurf-browser.org?rev=9670&view=rev Log: -Wextra is only understood by GCC 3.4.6 or later. It is a more descriptive synonym for -W. Use -W instead which is understood by all common versions of GCC (i.e. GCC 2.95 supports it, which is the oldest GCC version we have to support) Additionally, conditionalise our -Werror usage on whether we're building for BeOS/Haiku. On these platforms, the standard library headers result in warnings. GCC 2 is quite happy to build this code on other platforms, so shouldn't be the trigger for dropping -Werror (even if BeOS is the only target where GCC2 is likely to be used). Modified: trunk/libsvgtiny/Makefile Modified: trunk/libsvgtiny/Makefile URL: http://source.netsurf-browser.org/trunk/libsvgtiny/Makefile?rev=9670&r1=9... ============================================================================== --- trunk/libsvgtiny/Makefile (original) +++ trunk/libsvgtiny/Makefile Fri Nov 6 01:05:12 2009 @@ -10,11 +10,12 @@ TESTRUNNER := $(ECHO) # Toolchain flags -WARNFLAGS := -Wall -Wundef -Wpointer-arith -Wcast-align \ +WARNFLAGS := -Wall -W -Wundef -Wpointer-arith -Wcast-align \ -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes \ - -Wmissing-declarations -Wnested-externs -Werror -pedantic -ifneq ($(GCCVER),2) - WARNFLAGS := $(WARNFLAGS) -Wextra + -Wmissing-declarations -Wnested-externs -pedantic +# BeOS/Haiku standard library headers create warnings +ifneq ($(TARGET),beos) + WARNFLAGS := $(WARNFLAGS) -Werror endif CFLAGS := -D_BSD_SOURCE -I$(CURDIR)/include/ \ -I$(CURDIR)/src $(WARNFLAGS) $(CFLAGS)

13 years, 6 months

1
0
0 / 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

netsurf-commits November 2009