10:16 a.m.
Repo: https://git.gitano.org.uk/gitano.git
Ref: dsilvers/update-on-create
sha1: ec05045e9f29a9cb9f7d1a0a9d38b8b3d13275af
Without the update-server-info files, smart HTTP can fail and also gitweb and
the like get sad. This ensures that on realisation the files are created so
that the repo is immediately usable.
Test comes first (and will fail without the followon commit)
D.
Daniel Silverstone (2):
adds a test for server-info files in new repos
ensures server-info files exist on new repos
lib/gitano/repository.lua | 5 +++++
testing/02-commands-create.yarn | 13 +++++++++++++
2 files changed, 18 insertions(+)
--
2.1.4
10:16 a.m.
New subject: [PATCH 1/2] adds a test for server-info files in new repos
Even new repositories need http server info files.
---
testing/02-commands-create.yarn | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/testing/02-commands-create.yarn b/testing/02-commands-create.yarn
index 2b65fe5..b579e5b 100644
--- a/testing/02-commands-create.yarn
+++ b/testing/02-commands-create.yarn
@@ -25,3 +25,16 @@ comprehensible error message to that effect.
THEN stderr contains CRIT: Repository creation is not permitted.
FINALLY the instance is torn down
+
+When creating a repository, we update the HTTP server information file because
+that way gitweb and the like don't get upset even if nothing has been pushed,
+and HTTP smart access can be permitted, which might be necessary for the push
+in the first place.
+
+ SCENARIO created repositories have server info
+
+ GIVEN a standard instance
+
+ WHEN testinstance adminkey runs create foobar
+ THEN server-side foobar.git file objects/info/packs exists
+ AND server-side foobar.git file info/refs exists
--
2.1.4
10:16 a.m.
New subject: [PATCH 2/2] ensures server-info files exist on new repos
This change ensures that the server-info files are created
at the point that a repository is realised.
---
lib/gitano/repository.lua | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/gitano/repository.lua b/lib/gitano/repository.lua
index b66c343..b7e2ccc 100644
--- a/lib/gitano/repository.lua
+++ b/lib/gitano/repository.lua
@@ -489,6 +489,11 @@ function repo_method:realise()
self.git = r
self.is_nascent = nil
+ r, msg = self.git:update_server_info()
+ if not r then
+ return false, msg
+ end
+
-- Finally, we're not nascent, validate the repo
return self:run_checks()
end
--
2.1.4
10:58 a.m.
On Sat, Apr 08, 2017 at 03:16:50PM +0100, Daniel Silverstone wrote:
Repo: https://git.gitano.org.uk/gitano.git
Ref: dsilvers/update-on-create
sha1: ec05045e9f29a9cb9f7d1a0a9d38b8b3d13275af
Without the update-server-info files, smart HTTP can fail and also gitweb and
the like get sad. This ensures that on realisation the files are created so
that the repo is immediately usable.
Nice catch!
Test comes first (and will fail without the followon commit)
Thanks for providing a regression test.
I can imagine this is the kind of thing that can get broken during refactor.
I prefer if regression tests come after the code that fixes the bug
since it's nicer for bisection,
but I'm fairly sure the full-bisectability ship has already sailed,
so I haven't reordered your commits.
Thanks for the patch. I have merged it.
2243
days inactive
2243
days old
3 comments
2 participants
participants (2)
-
Daniel Silverstone -
Richard Maw