Re: [PATCHv2 2/2] Add section on git hooks
On 12 Apr 2017 16:08, "Daniel Silverstone" <dsilvers(a)digital-scurf.org>
wrote:
Since this is a second round review, I'm going to trim more heavily.
+# Git Hook scripts
+
+Gitano administrators may create, or delegate creation of
Perhaps worth a comma at the end of this line?
Possibly, though that would make the text read like Shatner to me.
+[Lua][lua] scripts to take action or provide further authentication
+when content is pushed to a repository.
+5. The `refname`, `oldsha` and `newsha` as the third to fifth
parameters
...second to fourth...
+6. For pre-receive or post-receive per-repository hooks as the
third
parameter,
...second...
In my defense I was both tired and drunk when I forgot to fix those.
+7. Global hooks work the same as per-repository hooks,
+ except their first parameter is instead a callable function
+ which will run the per-repository hook when called,
+ so global hooks may either replace or augment per-repository hooks.
...except they are passed a callable function first, followed by the
positional
parameters as described above. The callable will run the per-repository
hook when called, ...
Yep. I much prefer being explicit that the extra parameter doesn't stop the
rest from being passed too.
Otherwise I think it looks good.
If you're ok with the above changes, and don't think I've missed anything,
then I'm happy to apply these as part of a merge.
Works for me.
Attachments:
- attachment.htm (text/html — 3.0 KB)