Re: [PATCH] Add section on git hooks
On Mon, Apr 10, 2017 at 20:44:54 +0100, Richard Maw wrote:
To be fair, we don't have a story for external authentication
sources,
so perhaps we should experiment with how we _could_ do it that way,
perhaps modify the gitano rulesets to allow by default and check via hook.
That said, I don't think you can change the exit code via hook anyway,
so we can't really do anything about it.
You can call fatal() as discussed in person, but it's perhaps a bit of a pig
for this use-case. Let's think 2.x for that :-D>
> I'm afraid I don't follow. Why would you have to
check?
If you're defining a default hook
you should call the local hook if it exists rather than your own hook,
if it doesn't exist you should call your default hook implementation,
but you need to know whether your local hook exists.
Aaah I see, yeah that'd be a pain.
>From a reading of the code it looks like you never get a nil to
say it's absent
you get a callable that does nothing instead, to make the logic simpler.
Indeed. Perhaps I should find a way to signal that to the global hook; but not
for this version. A simple example, and referring to the examples/ tree in the
codebase is likely best for now.
D.
--
Daniel Silverstone http://www.digital-scurf.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69