[PATCH 0/2] Fix https://trello.com/c/7tlG7HCT/272
by Daniel Silverstone
Repo: git://git.gitano.org.uk/gitano.git
Ref: dsilvers/fix-272
SHA1: ec642db685d98a9fa264511a5c5ae0786ac0339d
When I consolidated the behaviour of multiple-value Lace values, I failed to
take into account that some of the values are both set-type and also list-type.
This results in a huge nasty traceback when the owner of a repo pushes an
adminref change containing a hook when using the default ruleset. This pair
of commits first exposes the problem by tweaking one of the treedelta tests
and then corrects it.
Daniel Silverstone (2):
TESTING: Use prefix instead of is
LACE: Correct a bug in iterating table form values
lib/gitano/lace.lua | 5 ++++-
testing/admin-patches/must-affect-FOO.patch | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
--
2.11.0
4 years, 9 months
Developer days
by Daniel Silverstone
Hi all,
Before I went incommunicado and hid from the project for six months, we were
doing regular Gitano developer days (https://wiki.gitano.org.uk/devday/) and
we'd had nearly nine months of regular developer days (the gap in August was
for Debconf where we released Gitano 1.0) and I'd like to get back to this.
Since I'm very much sat on my own right now, I propose sorting out a developer
day in April. 2017's April developer day was on the 8th April, so it might be
quite satisfying to have this year's first developer day on Saturday 7th April.
I don't yet know if that will be a purely online devday or if I will be able to
secure a location to have a physical meeting. If you're interested either way
then please respond to this thread, or poke me in private, and I'll use that to
help decide if I want to involve a physical venue.
Thanks,
Daniel.
--
Daniel Silverstone http://www.digital-scurf.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
5 years
Work left for 1.2
by Daniel Silverstone
Hi,
As promised, here's a brief redux of the work left for 1.2. This is all taken
from https://trello.com/b/l4Id6iiC/gitano and you are invited to go there and
read up on things yourself if you are considering working on them.
- https://trello.com/c/7tlG7HCT/272
This is about how the default ruleset seems to explode in a Lua traceback for
Lars Wirzenius. This is really not very good for a release version of Gitano
so it needs investigating with what's in Debian/stable initially and then
testing against current master of everything. If we've already fixed it then
we will need to make a bugfix release of the relevant bit for Debian users,
otherwise we need to fix it.
If noone else really wants to take this on, I'll probably do this after I've
finished reviewing the rest of the Trello (beyond things I mention in this
mail).
- https://trello.com/c/klOUAA0E/270 ## Low hanging fruit
This is about making Gitano preserve non-gitano content in the SSH authorized
keys file. At work we have a Gitano instance or three and sometimes the
ops people would like to be able to ssh into the gitano user without needing
to ssh in as something else and sudoing up. Since Gitano puts markers around
its content they assumed it would preserve content outside of it. It doesn't
and I think it's reasonable that it should.
While there's little on the card itself, I think this is quite easy for someone
new to Gitano to do, with a little guidance, and as such I have marked it as
low-hanging fruit.
If you are interested in working on this card, please let me know and I'll talk
you through anything I've not managed to put onto the card before then.
- https://trello.com/c/fN31Lh0Y/271 ## Low hanging fruit
This is about making the build system verify that the dependencies it has for
running the test suite are available *before* it tries to run the test suite.
This should be relatively easy for a newcomer who is passingly familiar with
GNU Make, and while there's little in the card now, if I've not filled it out
before you come to it, I will be pleased to assist.
- https://trello.com/c/bpvUhs4B/177
This is about making the internal HTTP client in the supple binding use
lua-http instead of shelling out to the curl binary. This work will need
someone who is at least reasonably familiar with Lua and probably someone who
is confident they can write some Yarn tests.
This is not a small amount of work, because of the need to add test cases to
cover the HTTP client functionality, but it's well worth it. Since lua-http
can be a server as well as a client, I'd probably like it if the tests used
a lua-http server rather than doing more with lighttpd.
- https://trello.com/c/xKEm2MsR/269
This is here because the gitano-bypass user which was introduced before 1.0
seems to be insufficient to clone a respository when the repository has a
bad adminref. This is a bug and also quite important to correct since the
purpose of the bypass user is to permit fixing this kind of issue without
having to resort to logging into the server itself.
- https://trello.com/c/vAKZdC44/273
The sshkey, whoami, etc commands are meant to be able to tell which ssh key is
in use during certain operations (marking the active SSH key in whoami output)
or refusing to delete the active sshkey when running sshkey del.
Sadly this is mostly done by keytag, which means that when using the 'as' command
we can end up with incorrectly identifying a target user's key as active.
This is moderately easily worked around, but it's annoying and not intended behaviour.
The above cover everything currently in the backlog or the '1.2 must' lane but
there's plenty more to do in the 1.2 nice, or the 1.x lanes. I'll be reviewing
the state of the Trello as my next task and as such, by the time you come to
read it, things may have changed, but if any of the above tweak your fancy, do
check they're not already done, and if they're not, let me know and I'll invite
you to the board so you can claim the card and do it :-)
Regards,
Daniel.
--
Daniel Silverstone http://www.digital-scurf.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
5 years
An apology and a fresh start
by Daniel Silverstone
Hi all,
This email is primarily to apologise for my absence over the past six months.
As such, here's approxiximately what has happened:
In September 2017 I ended up in hospital with a recurring condition I have.
This knocked me out for several weeks initially, and the recovery period is a
number of months to get me back to fully functional.
During that time, in order to reduce stress on myself I decided to drop working
on Gitano. Fortunately, Gitano is pretty solid at 1.0/1.1 and as such we've
not had any major bug reports come through which we weren't already aware of.
As with many things, once I was feeling well enough to work on free software again,
there were any number of other things which caught my attention and since I'm often
seduced by learning I ended up learning React (a JavaScript framework thingy) and
I wasn't really in a position to hack on a large Lua project at the same time.
Combining that with Lars working hard on ick2 and I didn't fancy working on the
Jenkins based CI which I was working on before I went into hospital means that
I was entirely uninspired to work on Gitano.
I've finally reached a point where I'd like to get back into Gitano work and so
while the above is no excuse it is, at least, a transparent reason. All I can
do is apologise for what I've not done and promise to be around going forward
unless something equally difficult takes me away. I'll also promise to *try*
and let you all know sooner if that happens.
The reason I say 'fresh start' in the subject is because I've marked all unread
mails in this box as read and I do not intend to read them. If you have been
involved in a thread which is *still* valid then I'd appreciate it if you would
either re-post the patches, or re-up the thread in question. I'll then do my
best to get around to reading them.
I'll be posting a mail to the list in a little while which covers the trello
cards remaining for 1.2 and what work I intend to tackle first.
If you're still here and interested in Gitano then thank you for sticking
around, and if this is the last straw and you decide to leave then thank you
for taking part until now and good luck in your future endeavours.
Regards,
Daniel.
--
Daniel Silverstone http://www.digital-scurf.org/
PGP mail accepted and encouraged. Key Id: 3CCE BABE 206C 3B69
5 years