On 07/13/2012 03:36 PM, Lars Wirzenius wrote:
On Fri, Jul 13, 2012 at 01:38:14PM +0100, Sam Thursfield wrote:
> + def _create_checksums(self, root):
> + # these are used to verify that there has been no btrfs corruption
The comment should be a docstring (and have proper capitalisation and
> + self.app.status(msg='Calculating checksums for
> + chatty=True)
> + with self.build_watch('checksum-rootfs'):
> + checksums = os.path.join(root, 'baserock',
I think I would like to have "md5" embedded in the filename so it's clear
what the checksum algorithm being used is.
Done - checksums.md5
> + with open(checksums, 'w') as f:
> + self.app.runcmd(['find', '.',
> + '-type', 'f',
> + '!', '-path',
That duplicates the name. Not a biggie, but might be cleaner to have the
name in a variable.
I tried, and it seemed to be a less clean.