On Fri, Sep 27, 2013 at 12:57:40PM +0100, Pedro Alvarez wrote:
On 25/09/13 15:25, Lars Wirzenius wrote:
> How long does it take to call ar.resolve_artifacts(srcpool)? Your code makes
> morph do that a second time. The point of doing this architecture validation
> check is to do it as early as possible, so the user does not need to wait a
> long time to get an error message.
Printing the times at the beginning of my code and at the end I get;
I think is fast, but:
That's fast enough to not be a worry right now.
> Is there a way to check the artifact before building srcpool, or
> doing that? That might be even faster.
I agree with you, I think it doesn't have to start doing anything (like
update the git repos). I'm trying to understand the morph code to do it
I think, due to the upcoming release, we can live with the code
executing twice, if we add a comment "# FIXME: This is executed twice,
> If the error message mentions cross-building, it should probably
> a hyphen in the word ("Cross-building", not "Cross building").
> there ways to make the error message better? Maybe something like "You
> must build natively: system architecture is %s but host architecture
> is %s". Opinions?
The error message is not a problem, could be whatever :)
Anyone have suggestions on the error message?
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/