3:30 a.m.
repo: git.baserock.org:baserock:baserock/morphs
branch: danielfirth/S8973
sha1: 27a948da2bc6f1121283b26d20fde8873e6d8ef2
4:21 a.m.
+1 from me, assuming you fix the quoting during merge. If you wish,
you can change the valid_archs ordering at the same time, but that's
not necessary.
On Mon, Oct 28, 2013 at 06:30:11PM +0000, Dan Firth wrote:
# List of architectures that Morph supports
-valid_archs = ['armv7l', 'armv7b', 'x86_32', 'x86_64']
+valid_archs = ['armv7l', 'armv7b', 'testarch', 'x86_32',
'x86_64']
I'd find it neater for testarch to be either the first or last one in
the list, not in the middle.
+ run_in "$DATADIR/gits/morphs" git add $MATCH_1.morph
The $MATCH_1 needs to be quoted in the above.
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/
7:16 p.m.
On Mon, Oct 28, 2013 at 06:30:11PM +0000, Dan Firth wrote:
repo: git.baserock.org:baserock:baserock/morphs
branch: danielfirth/S8973
sha1: 27a948da2bc6f1121283b26d20fde8873e6d8ef2
<snip>
+Implementation sections for building
+====================================
+
+ IMPLEMENTS WHEN attempting to build the system (\S+) in branch (\S+)
+ cd "$DATADIR/workspace/$MATCH_2"
+ attempt_morph build $MATCH_1 2> "$DATADIR/build_result"
--cachedir-min-space=0 --tempdir-min-space=0
It would be neater for this to be done for all morph build commands,
hence I would prefer altering the shell library which provides the
attempt_morph and run_morph commands to set min-space.
+
+ IMPLEMENTS THEN error message includes the string "(.*)"
+ grep "$MATCH_1" $DATADIR/build_result
Likewise it may be more convenient to make run_morph and attempt_morph
always write their output to a file.
8:25 p.m.
On 29/10/13 10:16, Richard Maw wrote:
It would be neater for this to be done for all morph build commands,
hence I would prefer altering the shell library which provides the
attempt_morph and run_morph commands to set min-space.
Likewise it may be more convenient to make run_morph and attempt_morph
always write their output to a file.
How's this?
11:15 p.m.
On Tue, Oct 29, 2013 at 10:16:41AM +0000, Richard Maw wrote:
On Mon, Oct 28, 2013 at 06:30:11PM +0000, Dan Firth wrote:
> repo: git.baserock.org:baserock:baserock/morphs
> branch: danielfirth/S8973
> sha1: 27a948da2bc6f1121283b26d20fde8873e6d8ef2
<snip>
> +Implementation sections for building
> +====================================
> +
> + IMPLEMENTS WHEN attempting to build the system (\S+) in branch (\S+)
> + cd "$DATADIR/workspace/$MATCH_2"
> + attempt_morph build $MATCH_1 2> "$DATADIR/build_result"
--cachedir-min-space=0 --tempdir-min-space=0
It would be neater for this to be done for all morph build commands,
hence I would prefer altering the shell library which provides the
attempt_morph and run_morph commands to set min-space.
I think we should have a $DATADIR/morph.conf, which includes the
cachedir-min-space and tempdir-min-space settings set to 0, and have
run_morph (and anything else that runs morph in the test suite) use
--no-default-config and --config to use that config file ONLY. I'd
prefer this over putting options in each invocation of morph in the
test suite.
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/
3621
days inactive
3622
days old
5 comments
4 participants
participants (4)
-
Dan Firth -
Lars Wirzenius -
Pedro Alvarez -
Richard Maw