On Fri, Dec 20, 2013 at 05:08:09PM +0000, Ben Brown wrote:
---
morphlib/plugins/artifact_inspection_plugin.py | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/morphlib/plugins/artifact_inspection_plugin.py
b/morphlib/plugins/artifact_inspection_plugin.py
index 6eeece7..882b237 100644
--- a/morphlib/plugins/artifact_inspection_plugin.py
+++ b/morphlib/plugins/artifact_inspection_plugin.py
@@ -122,16 +122,16 @@ class AutotoolsVersionGuesser(ProjectVersionGuesser):
['cut', '-d=', '-f2'],
['sed', "s/'//g"],
cwd=tempdir.root_path)
- version = None
- if output:
- output = output.strip()
- if output and output[0].isdigit():
- version = output
- if exit_code != 0:
- self.app.status(
- msg='%(repo)s: Failed to detect version from '
- '%(ref)s:%(filename)s',
- repo=repo, ref=ref, filename=filename, chatty=True)
+ version = None
+ if output:
+ output = output.strip()
+ if output and output[0].isdigit():
+ version = output
+ if exit_code != 0:
+ self.app.status(
+ msg='%(repo)s: Failed to detect version from '
+ '%(ref)s:%(filename)s',
+ repo=repo, ref=ref, filename=filename, chatty=True)
return version
I'm ambivalent to this patch. It doesn't matter whether the indentation
is changed, it just changes when the tempdir is removed.
If you want to make this change you have a +1.