On Wed, Sep 18, 2013 at 06:29:50PM +0100, Lars Wirzenius wrote:
On Wed, Sep 18, 2013 at 06:13:58PM +0100, Richard Maw wrote:
> On Wed, Sep 18, 2013 at 06:09:02PM +0100, Lars Wirzenius wrote:
> > Would everyone be OK if I merge my branch with the new upstream
> > release into bc-tarball's baserock/morph? +1 or -1 for this merge?
>
> For this change, yes, though I think we should also apply any of debian's
> patches that apply, since there's likely to be more than just debian
> integration patches there.
I looked at them. This seems the only one relevant to us, though I
admit I don't know what it does:
--- bc-1.06.95.orig/bc/main.c
+++ bc-1.06.95/bc/main.c
@@ -358,6 +358,9 @@
errno = save;
#else
write (1, "\n(interrupt) Exiting bc.\n", 26);
+#ifdef READLINE
+ rl_initialize (); /* Clear readline buffer */
+#endif
#if defined(LIBEDIT)
if (edit != NULL)
el_end(edit);
The rest is Debian packaging, or documentation tweaks, which I don't
care about.
Some research into the Debian changelog reveals this bug:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=287210
Summary: without this change, this will happen:
1
(interrupt) use quit to exit.
2+3
15
The input buffer (which contains "1") is not cleared when the user
types control-C. So the whole expression is "12+3", which is rather
surprising.
A minor bug, but we might as well fix it, I think. I'll add the patch,
and rebuild the system.
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/