Hi,
This is a bit of a reminder and a bit of a formalisation of process.
Up until now, changes to chunks have only needed a patch series including repo,
ref, sha and landing branch and the patch in question.
This was enough for us to merge the change and get it live.
Since we petrified master of definitions, this has changed.
We now need not only the chunk change, but *ALSO* a patch for definitions.
Eventually we will get morph to handle this for us during merge, but for now we
need explicit merge requests for both chunks and the associated definition
changes.
Submitters: Please try not to forget to provide an indication of what needs
changing in definitions (if not a patch)
Reviewers: Reject a patch series if it cannot go live due to a lack of
definitions changes. (Note, not every change is to something *in*
Baserock, e.g. baserock-chroot clearly doesn't need a definitions
change).
Mergers: DO NOT MERGE without a definitions change. When you have merged the
definitions change, *VERIFY* that the ref: fields are SHA1s (and correct)
and that the unpetrify-ref hasn't changed. It's worth remembering that
no matter the definitions provided by the submitter, the merger will likely
generate a different commit SHA1 due to name differences etc. use the SHA1
created during your merge, not any SHA1 provided by the submitter.
We'll review this as we go, but please please be aware of this need for now.
D.
--
Daniel Silverstone
http://www.codethink.co.uk/
Lead Architect GPG 4096/R Key Id: 3CCE BABE 206C 3B69