On Fri, Dec 07, 2012 at 03:57:46PM +0000, Richard Maw wrote:
On Fri, Dec 07, 2012 at 03:41:29PM +0000, Sam Thursfield wrote:
> Hi
>
> I always thought that we had the following policy when sending
> revised versions of patches:
>
> - Use the --in-reply-to=<message-id> parameter so that they appear
> within the same conversation thread. (The message ID should be that
> of the cover letter of your first patch, found in the mail headers)
>
> - Prepend "V2", "V3" etc to the title of the mail
>
> I notice none of this is mentioned in
>
http://wiki.baserock.org/contributing/, I'll add it, unless it turns
> out I've been wrong and our policy is something different.
+1
We haven't specified this anywhere, and while I do appreciate
patches
that are threaded in this way, I'm not sure it's a strong enough reason
to mandate it in policy.
We won't be punishing anyone for violating the guidelines on the
"contributing" page, but we should record our best practices there.
I do think that it is a useful suggestion to add to the contributing
page though.
In other words, we agree. :)
I do think it is worth making it a requirement that every merged
patch
is replied to, so that it is easier to see which patches have not been
reviewed.
+1
Sam, please update the page, and please add Richard's suggestion above.
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/