10:48 a.m.
repo: git.baserock.org/baserock/baserock/morph.git
branch: danielfirth/RT219
sha1: 9730481d7396236c23bca2cde8aef8ce1c6a12d6
Daniel Firth (1):
Morph now chdirs to the morphs repository before running extensions
morphlib/plugins/deploy_plugin.py | 1 +
1 file changed, 1 insertion(+)
--
1.8.1.2
10:48 a.m.
New subject: [PATCH] Morph now chdirs to the morphs repository before running extensions
---
morphlib/plugins/deploy_plugin.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/morphlib/plugins/deploy_plugin.py b/morphlib/plugins/deploy_plugin.py
index dc9f515..43c5988 100644
--- a/morphlib/plugins/deploy_plugin.py
+++ b/morphlib/plugins/deploy_plugin.py
@@ -458,6 +458,7 @@ class DeployPlugin(cliapp.Plugin):
self.app.status(msg='Running extension %(name)s%(kind)s',
name=name, kind=kind)
+ os.chdir(repo_dir)
self.app.runcmd(
[ext_filename] + args,
['sh', '-c', 'while read l; do echo `date "+%F
%T"` $l; done'],
--
1.8.1.2
11:14 a.m.
New subject: [PATCH] Morph now chdirs to the morphs repository before running extensions
On Wed, Sep 25, 2013 at 03:48:24PM +0100, Daniel Firth wrote:
+++ b/morphlib/plugins/deploy_plugin.py
@@ -458,6 +458,7 @@ class DeployPlugin(cliapp.Plugin):
self.app.status(msg='Running extension %(name)s%(kind)s',
name=name, kind=kind)
+ os.chdir(repo_dir)
self.app.runcmd(
[ext_filename] + args,
['sh', '-c', 'while read l; do echo `date "+%F
%T"` $l; done'],
It tends to be a bad idea to change the process's current working directory
unless we know for certain that no other part of the program assumes it is
unchanged. With Morph, we don't know that.
runcmd has a cwd=... parameter that can achieve the same effect, but
is less risky to use. It makes the change in the child process, before
execing the actual command.
Thus, -1 for this version of the patch. This is the right place to fix things,
though, it just needs to be done by adding the cwd named parameter to the
self.app.runcmd call.
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/
11:28 a.m.
New subject: [PATCH] Morph now chdirs to the morphs repository before running extensions
Not commenting on the patch itself, but please confirm that we're not hardcoding
anything for a repo named 'morphs' specifically?
In which case the summary of the patch purpose could be clearer, I think?
On 25 Sep 2013, at 10:48, Daniel Firth <dan.firth(a)codethink.co.uk> wrote:
---
morphlib/plugins/deploy_plugin.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/morphlib/plugins/deploy_plugin.py b/morphlib/plugins/deploy_plugin.py
index dc9f515..43c5988 100644
--- a/morphlib/plugins/deploy_plugin.py
+++ b/morphlib/plugins/deploy_plugin.py
@@ -458,6 +458,7 @@ class DeployPlugin(cliapp.Plugin):
self.app.status(msg='Running extension %(name)s%(kind)s',
name=name, kind=kind)
+ os.chdir(repo_dir)
self.app.runcmd(
[ext_filename] + args,
['sh', '-c', 'while read l; do echo `date "+%F
%T"` $l; done'],
--
1.8.1.2
_______________________________________________
baserock-dev mailing list
baserock-dev(a)baserock.org
http://vlists.pepperfish.net/cgi-bin/mailman/listinfo/baserock-dev-basero...
3544
days inactive
3544
days old
3 comments
3 participants
participants (3)
-
Daniel Firth -
Lars Wirzenius -
Paul Sherwood