On 01/06/17 13:28, Javier Jardón wrote:
On 25 May 2017 at 12:14, Sam Thursfield
Are those manual fixes documented somewhere?
Maybe a good place would be the defs2bst wiki?
They're documented in the commit log.
I don't think it makes sense to duplicate that info in a wiki. For each
case, it may or may not make sense to fix the tool so that the manual
fixes aren't needed ... I've not had time to dig into them yet.
I will personally be very happy to switch to BuildStream but as of
I see this blockers:
- Not a fully automated way to switch from definitions to BuildStream
format (or at least document
very carefully what steps should be done manually)
- Ideally I'd like to have this automated in the .gitlab-ci.yml, so
we can be sure the conversion
keeps working for a while before we switch 100% to buildstream
The steps to run the conversion are documented pretty carefully:
In terms of the conversion I did here, it should be repeatable by
running the `convert` script in the top directory of the branch. (It
just wraps defs2bst in currently a bit of a hacky way).
Certainly this initial conversion isn't the end of the story, I was
imagining that we rerun the conversion periodically and use Git history
to preserve the manual fixes. That would be a bit hard to automate from
.gitlab-ci.yml but would work for me for now.
Alternatively we could use .gitlab-ci.yml to run the convert script and
then do the extra fixes using `sed`. Although this is still blocked for
now by the issue Tristan mentioned that makes BuildStream builds fail on
- No cache server (kbas)
- No rpm output
I don't think this affects definitions.git itself, it might be a concern
for downstream projects.
Thanks for the feedback anyway! Sorry I took a while to reply.
Sam Thursfield, Codethink Ltd.
Office telephone: +44 161 236 5575