Re: [PATCH 0/7] Refactor morph status
On Tue, Sep 17, 2013 at 04:21:21PM +0100, Paul Sherwood wrote:
On 17/09/2013 16:12, Richard Maw wrote:
> Repo: git://git.baserock.org/baserock/baserock/morph.git
> Ref: baserock/richardmaw/S8511/refactor-status-v2
> SHA1: 601f39bca09fa52acadec3b908f29aecc241e868
> The amount of code sharing has increased, this makes me happy.
Sorry if I'm sounding cynical, but - "code sharing has increased", yet
the net effect of this patch is to add 142 lines?
The particular sharing is the code for finding git repositories or
system branches.
LOC will go down again when the old branch and merge code is removed.
I could make the next version of this patch series remove the old version
of status instead of renaming it out of the way if you think those metrics
would be useful.
We've been keeping the old versions in so that we have the new versions
in use, but if it becomes a problem, falling back to the old version is
less work than using an older version of morph.