Re: [PATCH 0/4 v2] Add a test suite for baserock-system-config-sync

On Thu, Jun 27, 2013 at 04:41:30PM +0100, Tiago Gomes wrote: > repo: ssh://git@git.baserock.org/baserock/baserock/tbdiff.git > branch: baserock/tiagogomes/bscs-test-suite > commit: 419af358bfb6d1fa0d937e1508963a92f14df0f0 I would have preferred if the new tests were integrated into the tbdiff test suite as separate scripts, rather than appended to the end of the run_tests.sh script, but given how specific the original test suite was I don't blame you for not wanting to touch it. I like the new test layout resembling the target device. I would prefer your fixups of run_tests.sh, i.e. making sure there is an `exit 1` when the command should have failed, were in a different commit to the one that runs check at the same time as install-recursive. Speaking of which, I don't think this is the right approach. I'd prefer that you run `make check` before `make install` in a morphology file, but I'm willing to be convinced otherwise. The morphology file can be simple. cat >tbdiff.morph <<'EOF' name: tbdiff kind: chunk build-system: autotools install-commands: - make check - make DESTDIR="$DESTDIR" install EOF

_______________________________________________ baserock-dev mailing list baserock-dev(a)baserock.org http://vlists.pepperfish.net/cgi-bin/mailman/listinfo/baserock-dev-basero...