Re: [PATCH] Write /etc/os-release in system images

On Fri, Oct 26, 2012 at 03:11:05PM +0100, Sam Thursfield wrote: > diff --git a/morphlib/builder2.py b/morphlib/builder2.py > index d376805..0de0ebf 100644 > --- a/morphlib/builder2.py > +++ b/morphlib/builder2.py > @@ -541,6 +542,18 @@ class SystemKindBuilder(BuilderBase): # pragma: no cover > > ldconfig(self.app.runcmd, path) > > + def write_metadata(self, instdir, artifact_name): > + BuilderBase.write_metadata(self, instdir, artifact_name) > + > + os_release_file = os.path.join(instdir, 'etc', 'os-release') > + if not os.path.exists(os.path.dirname(os_release_file)): > + os.makedirs(os.path.dirname(os_release_file)) > + with morphlib.savefile.SaveFile(os_release_file, 'w') as f: > + f.write('Baserock %s, built from ref %s on %s\n' % > + (self.artifact.source.morphology['name'], > + self.artifact.source.original_ref, > + datetime.date.today())) I'm not sure how useful the time will be, but we get traceability elsewhere, so it's nice as an extra feature. This looks fine to me, so I'm going to attempt a merge.