On Fri, Aug 31, 2012 at 04:52:16PM +0100, Lars Wirzenius wrote:
Troff tends to produce better formatted output if the source code
starts each new sentence on a new line. It's not worth rewriting
the patch for that, though, unless you've extra time.
On Fri, Aug 31, 2012 at 02:31:27PM +0100, Joel Dillon wrote:
> +A chunk is a git repository based on an individual upstream project's revision
> +control system (converted into git if upstream does not already use it), which
> +contains a branch named 'baserock', that both contains a JSON configuration
> +defining how to build the chunk and any other changes required to get the
> +repository to build with the rest of Baserock.
Nitpick: There's no need for a chunk to contain any special branches. Any git
repo can work, as long as the automatic build rules built into morph work.
However, that may be going into too much detail.
Apart from these and my earlier remarks, I'm OK with this patch and happy
to see it merged into master.
I have now done the merge and pushed.